From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40823) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RORDe-0006aA-In for qemu-devel@nongnu.org; Thu, 10 Nov 2011 04:46:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RORDd-00004r-A7 for qemu-devel@nongnu.org; Thu, 10 Nov 2011 04:46:50 -0500 Received: from cantor2.suse.de ([195.135.220.15]:58750 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RORDc-0008WT-VV for qemu-devel@nongnu.org; Thu, 10 Nov 2011 04:46:49 -0500 Message-ID: <4EBB9D80.3000705@suse.de> Date: Thu, 10 Nov 2011 10:46:40 +0100 From: =?windows-1252?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1320802728-21841-1-git-send-email-agraf@suse.de> <4EBA16A1.9090703@weilnetz.de> <4EBA558A.20707@suse.de> <20111109104751.3b5a028d@doriath> <4EBB7046.1070308@weilnetz.de> In-Reply-To: <4EBB7046.1070308@weilnetz.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] pci-stub: fix compile breakage with qmp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil , Anthony Liguori Cc: qemu-devel@nongnu.org, Alexander Graf , Luiz Capitulino Am 10.11.2011 07:33, schrieb Stefan Weil: > Am 10.11.2011 00:45, schrieb Alexander Graf: >> >> On 09.11.2011, at 13:47, Luiz Capitulino wrote: >> >>> On Wed, 09 Nov 2011 11:27:22 +0100 >>> Andreas F=E4rber wrote: >>> >>>> Am 09.11.2011 06:58, schrieb Stefan Weil: >>>>> No. Simply remove */qmp-commands.h. They are relicts from previous >>>>> builds. >>>> >>>> If make clean didn't help, please patch that instead then. >>> >>> So, did it fix the problem for you Alex? >> >> Yup :). However, if I run into this other users / developers will too. >> >> >> Alex >=20 > Hi Alex, >=20 > there is a rather simple solution for this kind of problems: > don't run make in your source tree. >=20 > QEMU supports out-of-tree builds since several years now. > So this helps: >=20 > # Run the following commands from QEMU's source root directory. > rm -rf bin && mkdir bin && cd bin && ../configure && make >=20 > This also allows several build directories with different configuration= s. > I use for example different trees for fast builds without compiler > optimization and full debugging and for production builds. > By the way: CFLAGS=3D-g is also very useful for build bots! >=20 > bin/debug # directory configured with --enable-debug and CFLAGS=3D-g > bin/ndebug # directory with default settings and compiler optimization Stefan and Anthony, I usually do build out-of-tree but that suggestion still ignores the issue that cleaning the build, whether in-tree or out-of-tree, before a pull defeats the whole purpose of dependency-based conditional compilation and wastes a lot of time. Removing these stale generated files should've been something Luis' patch should've been doing IMO, then it's easily reviewable and testable; now we can still verify by doing a checkout and build of the predecessor commit and HEAD, and pulling that in through qemu-trivial doesn't cost you, Anthony, a lot of time if you don't see our point. :) Hell, we still clean up dyngen files in Makefile so let's not be too lazy to clean up things that actually do break the build for core contributors! If Alex doesn't beat me I'll look into it next time I have a long-running test case. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg