From: Paolo Bonzini <pbonzini@redhat.com>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] x86_64 linux kernel doesn't boot with -icount enabled
Date: Thu, 10 Nov 2011 12:25:40 +0100 [thread overview]
Message-ID: <4EBBB4B4.8030103@redhat.com> (raw)
In-Reply-To: <CAMo8BfJuWNLQDQx2N=hQ7g6stsXO1J3TUqhqUx4u+ExHpoQhOQ@mail.gmail.com>
On 11/10/2011 11:25 AM, Max Filippov wrote:
>> >
>> > -icount should be ignored or give an error together with KVM. Would you
> What's the background for that? (Unfortunately I'm completely
> unfamiliar with kvm).
>
With -icount, The vm_clock is updated with help from TCG (it counts
instructions at 2^ICOUNT ns/instructions). With KVM, the instruction
count is not available so KVM cannot provide this help.
The patch you sent looks good, but perhaps you can include the above
comment in the commit message and also include Xen? With these changes,
you can add my Acked-by.
Thanks,
Paolo
next prev parent reply other threads:[~2011-11-10 11:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 13:45 [Qemu-devel] x86_64 linux kernel doesn't boot with -icount enabled Max Filippov
2011-11-08 14:03 ` Max Filippov
2011-11-08 14:14 ` Paolo Bonzini
2011-11-08 14:21 ` Max Filippov
2011-11-08 15:52 ` Max Filippov
2011-11-09 9:41 ` Cao,Bing Bu
2011-11-09 10:42 ` Cao,Bing Bu
2011-11-09 10:50 ` Max Filippov
2011-11-10 2:54 ` Cao,Bing Bu
2011-11-10 9:05 ` Max Filippov
2011-11-10 9:15 ` Paolo Bonzini
2011-11-10 10:25 ` Max Filippov
2011-11-10 11:25 ` Paolo Bonzini [this message]
2011-11-11 7:09 ` [Qemu-devel] [PATCH] Give an error when using -icount option with kvm accelerator Cao,Bing Bu
2011-11-14 6:17 ` Cao,Bing Bu
2011-11-13 21:57 ` [Qemu-devel] x86_64 linux kernel doesn't boot with -icount enabled Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBBB4B4.8030103@redhat.com \
--to=pbonzini@redhat.com \
--cc=jcmvbkbc@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).