From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34084) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ROauR-0000Gl-Os for qemu-devel@nongnu.org; Thu, 10 Nov 2011 15:07:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ROauQ-0000Ml-Ds for qemu-devel@nongnu.org; Thu, 10 Nov 2011 15:07:39 -0500 Received: from mail-vw0-f45.google.com ([209.85.212.45]:58292) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ROauQ-0000Mg-8l for qemu-devel@nongnu.org; Thu, 10 Nov 2011 15:07:38 -0500 Received: by vws17 with SMTP id 17so3088453vws.4 for ; Thu, 10 Nov 2011 12:07:37 -0800 (PST) Message-ID: <4EBC2F05.7080500@codemonkey.ws> Date: Thu, 10 Nov 2011 14:07:33 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <4EBAAA68.10801@redhat.com> <4EBAACAF.4080407@codemonkey.ws> <4EBAB236.2060409@redhat.com> <4EBAB9FA.3070601@codemonkey.ws> <4EBB919B.7040605@redhat.com> <4EBC1792.3030004@codemonkey.ws> <20111110184200.GC17987@redhat.com> <4EBC21EE.2010102@codemonkey.ws> <20111110200609.GB4941@redhat.com> In-Reply-To: <20111110200609.GB4941@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] qemu and qemu.git -> Migration + disk stress introduces qcow2 corruptions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Lucas Meneghel Rodrigues , Kevin Wolf , KVM mailing list , "Michael S. Tsirkin" , "libvir-list@redhat.com" , Marcelo Tosatti , QEMU devel , Juan Jose Quintela Carreira , Avi Kivity On 11/10/2011 02:06 PM, Daniel P. Berrange wrote: > On Thu, Nov 10, 2011 at 01:11:42PM -0600, Anthony Liguori wrote: >> On 11/10/2011 12:42 PM, Daniel P. Berrange wrote: >>> On Thu, Nov 10, 2011 at 12:27:30PM -0600, Anthony Liguori wrote: >>>> What does libvirt actually do in the monitor prior to migration >>>> completing on the destination? The least invasive way of doing >>>> delayed open of block devices is probably to make -incoming create a >>>> monitor and run a main loop before the block devices (and full >>>> device model) is initialized. Since this isolates the changes >>>> strictly to migration, I'd feel okay doing this for 1.0 (although it >>>> might need to be in the stable branch). >>> >>> The way migration works with libvirt wrt QEMU interactions is now >>> as follows >>> >>> 1. Destination. >>> Run qemu -incoming ...args... >>> Query chardevs via monitor >>> Query vCPU threads via monitor >>> Set disk / vnc passwords >> >> Since RHEL carries Juan's patch, and Juan's patch doesn't handle >> disk passwords gracefully, how does libvirt cope with that? > > No idea, that's the first I've heard of any patch that causes > problems with passwords in QEMU. My guess is that migration with a password protected qcow2 file isn't a common test-case. Regards, Anthony Liguori > > Daniel