From: "Andreas Färber" <afaerber@suse.de>
To: 陳韋任 <chenwj@iis.sinica.edu.tw>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/6 v2] tests/Makefile: Remove qruncom target
Date: Fri, 11 Nov 2011 16:19:09 +0100 [thread overview]
Message-ID: <4EBD3CED.4010402@suse.de> (raw)
In-Reply-To: <20111111150755.GA39686@cs.nctu.edu.tw>
Am 11.11.2011 16:07, schrieb 陳韋任:
> On Fri, Nov 11, 2011 at 03:02:16PM +0000, Peter Maydell wrote:
>> On 11 November 2011 14:53, Chen Wei-Ren (陳韋任) <chenwj@iis.sinica.edu.tw> wrote:
>>> From: Chen Wei-Ren <chenwj@iis.sinica.edu.tw>
>>>
>>> Remove qruncom target from the Makefile file since we have
>>> removed libqemu example (qruncom.c).
>>
>> This should be done before the patch removing qruncom.c, not after.
>> Or do both in the same patch.
>
> I'll reverse the order next time. Is there a rule of thumb about how
> to order those patches?
The logic goes like this: Every single patch should build / work.
If you remove the sources, the Makefile rule no longer works.
If you remove the Makefile rule, the sources are not used.
Therefore best just squash these two commits together.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2011-11-11 15:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 14:53 [Qemu-devel] [PATCH 0/6 v2] Remove libqemu related stuff from QEMU source tree Chen Wei-Ren (陳韋任)
2011-11-11 14:53 ` [Qemu-devel] [PATCH 1/6 v2] tests/qruncom.c: Remove libqemu.a example Chen Wei-Ren (陳韋任)
2011-11-11 14:53 ` [Qemu-devel] [PATCH 2/6 v2] tests/Makefile: Remove qruncom target Chen Wei-Ren (陳韋任)
2011-11-11 15:02 ` Peter Maydell
2011-11-11 15:07 ` 陳韋任
2011-11-11 15:16 ` Peter Maydell
2011-11-11 15:19 ` Andreas Färber [this message]
2011-11-11 14:53 ` [Qemu-devel] [PATCH 3/6 v2] qemu-tech.texi: Remove libqemu related stuff from the document Chen Wei-Ren (陳韋任)
2011-11-11 14:53 ` [Qemu-devel] [PATCH 4/6 v2] Makefile.target: Remove libqemu target Chen Wei-Ren (陳韋任)
2011-11-11 15:00 ` Peter Maydell
2011-11-11 15:15 ` 陳韋任
2011-11-11 14:53 ` [Qemu-devel] [PATCH 5/6 v2] Makefile.objs: Remove libqemu_common.a from the comment Chen Wei-Ren (陳韋任)
2011-11-11 14:53 ` [Qemu-devel] [PATCH 6/6 v2] LICENSE: There is no libqemu.a anymore Chen Wei-Ren (陳韋任)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBD3CED.4010402@suse.de \
--to=afaerber@suse.de \
--cc=chenwj@iis.sinica.edu.tw \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).