From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:49379)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ROst0-0007tB-1X
	for qemu-devel@nongnu.org; Fri, 11 Nov 2011 10:19:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ROssy-0001OP-UY
	for qemu-devel@nongnu.org; Fri, 11 Nov 2011 10:19:21 -0500
Received: from cantor2.suse.de ([195.135.220.15]:34719 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ROssy-0001OJ-Oi
	for qemu-devel@nongnu.org; Fri, 11 Nov 2011 10:19:20 -0500
Message-ID: <4EBD3CED.4010402@suse.de>
Date: Fri, 11 Nov 2011 16:19:09 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1321023211-34566-1-git-send-email-chenwj@iis.sinica.edu.tw>
	<1321023211-34566-3-git-send-email-chenwj@iis.sinica.edu.tw>
	<CAFEAcA8PucPWBZZAWZ5yEAPx0F5t0arN11DykcW0BByA6BunbA@mail.gmail.com>
	<20111111150755.GA39686@cs.nctu.edu.tw>
In-Reply-To: <20111111150755.GA39686@cs.nctu.edu.tw>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 2/6 v2] tests/Makefile: Remove qruncom
	target
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?6Zmz6Z+L5Lu7?= <chenwj@iis.sinica.edu.tw>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org

Am 11.11.2011 16:07, schrieb =E9=99=B3=E9=9F=8B=E4=BB=BB:
> On Fri, Nov 11, 2011 at 03:02:16PM +0000, Peter Maydell wrote:
>> On 11 November 2011 14:53, Chen Wei-Ren (=E9=99=B3=E9=9F=8B=E4=BB=BB) =
<chenwj@iis.sinica.edu.tw> wrote:
>>> From: Chen Wei-Ren <chenwj@iis.sinica.edu.tw>
>>>
>>>  Remove qruncom target from the Makefile file since we have
>>> removed libqemu example (qruncom.c).
>>
>> This should be done before the patch removing qruncom.c, not after.
>> Or do both in the same patch.
>=20
>   I'll reverse the order next time. Is there a rule of thumb about how
> to order those patches?

The logic goes like this: Every single patch should build / work.

If you remove the sources, the Makefile rule no longer works.
If you remove the Makefile rule, the sources are not used.

Therefore best just squash these two commits together.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg