From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:35249)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1ROwAX-00010U-7x
	for qemu-devel@nongnu.org; Fri, 11 Nov 2011 13:49:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1ROwAV-0004Bu-RB
	for qemu-devel@nongnu.org; Fri, 11 Nov 2011 13:49:41 -0500
Received: from mail-yw0-f45.google.com ([209.85.213.45]:52724)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1ROwAV-0004Bp-MQ
	for qemu-devel@nongnu.org; Fri, 11 Nov 2011 13:49:39 -0500
Received: by ywa17 with SMTP id 17so737951ywa.4
	for <qemu-devel@nongnu.org>; Fri, 11 Nov 2011 10:49:39 -0800 (PST)
Message-ID: <4EBD6E3F.7020209@codemonkey.ws>
Date: Fri, 11 Nov 2011 12:49:35 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1320864854-19470-1-git-send-email-pavel.borzenkov@gmail.com>
In-Reply-To: <1320864854-19470-1-git-send-email-pavel.borzenkov@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1.0] configure: add '--disable-cocoa' switch
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Cc: andreas.faerber@web.de, qemu-devel@nongnu.org

On 11/09/2011 12:54 PM, Pavel Borzenkov wrote:
> When SDL support is disabled, there is no way to build QEMU without
> Cocoa support on MacOS X. This patch adds '--disable-cocoa' switch and
> allows to build QEMU without both SDL and Cocoa frontends.
>
> Signed-off-by: Pavel Borzenkov<pavel.borzenkov@gmail.com>

This breaks SDL probing on Linux.

> ---
>   configure |   11 ++++++-----
>   1 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/configure b/configure
> index 9e5da44..ba3a830 100755
> --- a/configure
> +++ b/configure
> @@ -669,6 +669,8 @@ for opt do
>     ;;
>     --enable-profiler) profiler="yes"
>     ;;
> +  --disable-cocoa) cocoa="no"
> +  ;;
>     --enable-cocoa)
>         cocoa="yes" ;
>         sdl="no" ;
> @@ -979,7 +981,10 @@ echo "  --disable-sdl            disable SDL"
>   echo "  --enable-sdl             enable SDL"
>   echo "  --disable-vnc            disable VNC"
>   echo "  --enable-vnc             enable VNC"
> -echo "  --enable-cocoa           enable COCOA (Mac OS X only)"
> +if test "$darwin" = "yes" ; then
> +    echo "  --disable-cocoa          disable COCOA"
> +    echo "  --enable-cocoa           enable COCOA"
> +fi
>   echo "  --audio-drv-list=LIST    set audio drivers list:"
>   echo "                           Available drivers: $audio_possible_drivers"
>   echo "  --audio-card-list=LIST   set list of emulated audio cards [$audio_card_list]"
> @@ -1424,10 +1429,6 @@ EOF
>     if compile_prog "$sdl_cflags" "$sdl_libs" ; then
>       if test "$_sdlversion" -lt 121 ; then
>         sdl_too_old=yes
> -    else
> -      if test "$cocoa" = "no" ; then
> -        sdl=yes
> -      fi

This is what normally enables SDL.

Regards,

Anthony Liguori
>       fi
>
>       # static link with sdl ? (note: sdl.pc's --static --libs is broken)