From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:52111)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1ROx2L-00031B-HJ
	for qemu-devel@nongnu.org; Fri, 11 Nov 2011 14:45:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1ROx2K-0001wQ-6w
	for qemu-devel@nongnu.org; Fri, 11 Nov 2011 14:45:17 -0500
Message-ID: <4EBD7B48.1060407@codemonkey.ws>
Date: Fri, 11 Nov 2011 13:45:12 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1320867268-10015-1-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1320867268-10015-1-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] hw/tc58128.c: Remove unnecessary check for
 g_malloc failure
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, patches@linaro.org

On 11/09/2011 01:34 PM, Peter Maydell wrote:
> Remove a check for g_malloc failing: this never happens.
> Also use g_malloc rather than g_malloc0 as we immediately
> memset the entire region and so zero-initialising it is pointless.
> Spotted by Coverity (see bug 887883).
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   hw/tc58128.c |    6 +-----
>   1 files changed, 1 insertions(+), 5 deletions(-)
>
> diff --git a/hw/tc58128.c b/hw/tc58128.c
> index ee3ecad..4ce80b1 100644
> --- a/hw/tc58128.c
> +++ b/hw/tc58128.c
> @@ -30,12 +30,8 @@ static void init_dev(tc58128_dev * dev, const char *filename)
>       int ret, blocks;
>
>       dev->state = WAIT;
> -    dev->flash_contents = g_malloc0(FLASH_SIZE);
> +    dev->flash_contents = g_malloc(FLASH_SIZE);
>       memset(dev->flash_contents, 0xff, FLASH_SIZE);
> -    if (!dev->flash_contents) {
> -	fprintf(stderr, "could not alloc memory for flash\n");
> -	exit(1);
> -    }
>       if (filename) {
>   	/* Load flash image skipping the first block */
>   	ret = load_image(filename, dev->flash_contents + 528 * 32);