* [Qemu-devel] [PATCH] hw/tc58128.c: Remove unnecessary check for g_malloc failure
@ 2011-11-09 19:34 Peter Maydell
2011-11-10 11:35 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2011-11-11 19:45 ` [Qemu-devel] " Anthony Liguori
0 siblings, 2 replies; 3+ messages in thread
From: Peter Maydell @ 2011-11-09 19:34 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, patches
Remove a check for g_malloc failing: this never happens.
Also use g_malloc rather than g_malloc0 as we immediately
memset the entire region and so zero-initialising it is pointless.
Spotted by Coverity (see bug 887883).
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/tc58128.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/hw/tc58128.c b/hw/tc58128.c
index ee3ecad..4ce80b1 100644
--- a/hw/tc58128.c
+++ b/hw/tc58128.c
@@ -30,12 +30,8 @@ static void init_dev(tc58128_dev * dev, const char *filename)
int ret, blocks;
dev->state = WAIT;
- dev->flash_contents = g_malloc0(FLASH_SIZE);
+ dev->flash_contents = g_malloc(FLASH_SIZE);
memset(dev->flash_contents, 0xff, FLASH_SIZE);
- if (!dev->flash_contents) {
- fprintf(stderr, "could not alloc memory for flash\n");
- exit(1);
- }
if (filename) {
/* Load flash image skipping the first block */
ret = load_image(filename, dev->flash_contents + 528 * 32);
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/tc58128.c: Remove unnecessary check for g_malloc failure
2011-11-09 19:34 [Qemu-devel] [PATCH] hw/tc58128.c: Remove unnecessary check for g_malloc failure Peter Maydell
@ 2011-11-10 11:35 ` Stefan Hajnoczi
2011-11-11 19:45 ` [Qemu-devel] " Anthony Liguori
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2011-11-10 11:35 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-trivial, qemu-devel, patches
On Wed, Nov 09, 2011 at 07:34:28PM +0000, Peter Maydell wrote:
> Remove a check for g_malloc failing: this never happens.
> Also use g_malloc rather than g_malloc0 as we immediately
> memset the entire region and so zero-initialising it is pointless.
> Spotted by Coverity (see bug 887883).
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/tc58128.c | 6 +-----
> 1 files changed, 1 insertions(+), 5 deletions(-)
Thanks, applied to the trivial patches tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/tc58128.c: Remove unnecessary check for g_malloc failure
2011-11-09 19:34 [Qemu-devel] [PATCH] hw/tc58128.c: Remove unnecessary check for g_malloc failure Peter Maydell
2011-11-10 11:35 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
@ 2011-11-11 19:45 ` Anthony Liguori
1 sibling, 0 replies; 3+ messages in thread
From: Anthony Liguori @ 2011-11-11 19:45 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-trivial, qemu-devel, patches
On 11/09/2011 01:34 PM, Peter Maydell wrote:
> Remove a check for g_malloc failing: this never happens.
> Also use g_malloc rather than g_malloc0 as we immediately
> memset the entire region and so zero-initialising it is pointless.
> Spotted by Coverity (see bug 887883).
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> hw/tc58128.c | 6 +-----
> 1 files changed, 1 insertions(+), 5 deletions(-)
>
> diff --git a/hw/tc58128.c b/hw/tc58128.c
> index ee3ecad..4ce80b1 100644
> --- a/hw/tc58128.c
> +++ b/hw/tc58128.c
> @@ -30,12 +30,8 @@ static void init_dev(tc58128_dev * dev, const char *filename)
> int ret, blocks;
>
> dev->state = WAIT;
> - dev->flash_contents = g_malloc0(FLASH_SIZE);
> + dev->flash_contents = g_malloc(FLASH_SIZE);
> memset(dev->flash_contents, 0xff, FLASH_SIZE);
> - if (!dev->flash_contents) {
> - fprintf(stderr, "could not alloc memory for flash\n");
> - exit(1);
> - }
> if (filename) {
> /* Load flash image skipping the first block */
> ret = load_image(filename, dev->flash_contents + 528 * 32);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-11 19:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-09 19:34 [Qemu-devel] [PATCH] hw/tc58128.c: Remove unnecessary check for g_malloc failure Peter Maydell
2011-11-10 11:35 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2011-11-11 19:45 ` [Qemu-devel] " Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).