* [Qemu-devel] [PATCH] hw/pl061: Remove pointless comparison of array to null
@ 2011-11-09 20:04 Peter Maydell
2011-11-11 19:45 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Peter Maydell @ 2011-11-09 20:04 UTC (permalink / raw)
To: qemu-devel; +Cc: patches
Remove a pointless comparison of an array to null. (There is
no need to check whether s->out[i] is non-null as qemu_set_irq
will do that for us.) Spotted by Coverity (see bug 887883).
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/pl061.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/pl061.c b/hw/pl061.c
index d13746c..cf5adbe 100644
--- a/hw/pl061.c
+++ b/hw/pl061.c
@@ -103,7 +103,7 @@ static void pl061_update(pl061_state *s)
s->old_data = out;
for (i = 0; i < 8; i++) {
mask = 1 << i;
- if ((changed & mask) && s->out) {
+ if (changed & mask) {
DPRINTF("Set output %d = %d\n", i, (out & mask) != 0);
qemu_set_irq(s->out[i], (out & mask) != 0);
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/pl061: Remove pointless comparison of array to null
2011-11-09 20:04 [Qemu-devel] [PATCH] hw/pl061: Remove pointless comparison of array to null Peter Maydell
@ 2011-11-11 19:45 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2011-11-11 19:45 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-devel, patches
On 11/09/2011 02:04 PM, Peter Maydell wrote:
> Remove a pointless comparison of an array to null. (There is
> no need to check whether s->out[i] is non-null as qemu_set_irq
> will do that for us.) Spotted by Coverity (see bug 887883).
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> hw/pl061.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/pl061.c b/hw/pl061.c
> index d13746c..cf5adbe 100644
> --- a/hw/pl061.c
> +++ b/hw/pl061.c
> @@ -103,7 +103,7 @@ static void pl061_update(pl061_state *s)
> s->old_data = out;
> for (i = 0; i< 8; i++) {
> mask = 1<< i;
> - if ((changed& mask)&& s->out) {
> + if (changed& mask) {
> DPRINTF("Set output %d = %d\n", i, (out& mask) != 0);
> qemu_set_irq(s->out[i], (out& mask) != 0);
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-11 19:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-09 20:04 [Qemu-devel] [PATCH] hw/pl061: Remove pointless comparison of array to null Peter Maydell
2011-11-11 19:45 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).