From: Anthony Liguori <anthony@codemonkey.ws>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] vl.c: prohibit simultaneous use of -icount with kvm or xen
Date: Fri, 11 Nov 2011 13:45:59 -0600 [thread overview]
Message-ID: <4EBD7B77.6040904@codemonkey.ws> (raw)
In-Reply-To: <1320925122-4422-1-git-send-email-jcmvbkbc@gmail.com>
On 11/10/2011 05:38 AM, Max Filippov wrote:
> With -icount, The vm_clock is updated with help from TCG (it counts
> instructions at 2^ICOUNT ns/instructions). With KVM, the instruction
> count is not available so KVM cannot provide this help.
>
> Signed-off-by: Max Filippov<jcmvbkbc@gmail.com>
> Acked-by: Paolo Bonzini<pbonzini@redhat.com>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> v1 -> v2 changes:
> - cover both kvm and xen;
> - add explanation text.
> ---
> vl.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index f169aac..bb601e2 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3226,6 +3226,11 @@ int main(int argc, char **argv, char **envp)
> fprintf(stderr, "could not initialize alarm timer\n");
> exit(1);
> }
> +
> + if (icount_option&& (kvm_enabled() || xen_enabled())) {
> + fprintf(stderr, "-icount is not allowed with kvm or xen\n");
> + exit(1);
> + }
> configure_icount(icount_option);
>
> if (net_init_clients()< 0) {
next prev parent reply other threads:[~2011-11-11 19:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 11:38 [Qemu-devel] [PATCH v2] vl.c: prohibit simultaneous use of -icount with kvm or xen Max Filippov
2011-11-11 19:45 ` Anthony Liguori
2011-11-11 19:45 ` Anthony Liguori [this message]
2012-08-22 16:51 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBD7B77.6040904@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=jcmvbkbc@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).