From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:52534)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1ROx3R-0006XD-OK
	for qemu-devel@nongnu.org; Fri, 11 Nov 2011 14:46:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1ROx3K-0002Db-Cr
	for qemu-devel@nongnu.org; Fri, 11 Nov 2011 14:46:25 -0500
Received: from mail-gy0-f173.google.com ([209.85.160.173]:54481)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1ROx3K-0002BC-AQ
	for qemu-devel@nongnu.org; Fri, 11 Nov 2011 14:46:18 -0500
Received: by gyb11 with SMTP id 11so3672346gyb.4
	for <qemu-devel@nongnu.org>; Fri, 11 Nov 2011 11:46:02 -0800 (PST)
Message-ID: <4EBD7B77.6040904@codemonkey.ws>
Date: Fri, 11 Nov 2011 13:45:59 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1320925122-4422-1-git-send-email-jcmvbkbc@gmail.com>
In-Reply-To: <1320925122-4422-1-git-send-email-jcmvbkbc@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] vl.c: prohibit simultaneous use of
 -icount with kvm or xen
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

On 11/10/2011 05:38 AM, Max Filippov wrote:
> With -icount, The vm_clock is updated with help from TCG (it counts
> instructions at 2^ICOUNT ns/instructions). With KVM, the instruction
> count is not available so KVM cannot provide this help.
>
> Signed-off-by: Max Filippov<jcmvbkbc@gmail.com>
> Acked-by: Paolo Bonzini<pbonzini@redhat.com>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
> v1 ->  v2 changes:
> - cover both kvm and xen;
> - add explanation text.
> ---
>   vl.c |    5 +++++
>   1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index f169aac..bb601e2 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3226,6 +3226,11 @@ int main(int argc, char **argv, char **envp)
>           fprintf(stderr, "could not initialize alarm timer\n");
>           exit(1);
>       }
> +
> +    if (icount_option&&  (kvm_enabled() || xen_enabled())) {
> +        fprintf(stderr, "-icount is not allowed with kvm or xen\n");
> +        exit(1);
> +    }
>       configure_icount(icount_option);
>
>       if (net_init_clients()<  0) {