From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:52494)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1ROx3F-0006A8-Nl
	for qemu-devel@nongnu.org; Fri, 11 Nov 2011 14:46:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1ROx3E-0002Cq-Hr
	for qemu-devel@nongnu.org; Fri, 11 Nov 2011 14:46:13 -0500
Received: from mail-iy0-f173.google.com ([209.85.210.173]:35059)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1ROx3E-0001is-En
	for qemu-devel@nongnu.org; Fri, 11 Nov 2011 14:46:12 -0500
Received: by mail-iy0-f173.google.com with SMTP id k32so5202243iak.4
	for <qemu-devel@nongnu.org>; Fri, 11 Nov 2011 11:46:12 -0800 (PST)
Message-ID: <4EBD7B7F.2090308@codemonkey.ws>
Date: Fri, 11 Nov 2011 13:46:07 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1320956819-91322-1-git-send-email-pavel.borzenkov@gmail.com>
In-Reply-To: <1320956819-91322-1-git-send-email-pavel.borzenkov@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1.0] configure: Do not use 'sed -i'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org

On 11/10/2011 02:26 PM, Pavel Borzenkov wrote:
> 'sed -i' is not defined in POSIX. It doesn't work on Mac OS X the way
> it's used in configure (without suffix argument). This patch implements
> Peter Maydell's idea of xattr.h detection.
>
> Cc: Peter Maydell<peter.maydell@linaro.org>
> Signed-off-by: Pavel Borzenkov<pavel.borzenkov@gmail.com>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   configure |    6 +++++-
>   1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index 401d9a6..d6103c0 100755
> --- a/configure
> +++ b/configure
> @@ -1962,13 +1962,17 @@ if test "$attr" != "no" ; then
>     cat>  $TMPC<<EOF
>   #include<stdio.h>
>   #include<sys/types.h>
> +#ifdef CONFIG_LIBATTR
> +#include<attr/xattr.h>
> +#else
>   #include<sys/xattr.h>
> +#endif
>   int main(void) { getxattr(NULL, NULL, NULL, 0); setxattr(NULL, NULL, NULL, 0, 0); return 0; }
>   EOF
>     if compile_prog "" "" ; then
>       attr=yes
>     # Older distros have<attr/xattr.h>, and need -lattr:
> -  elif sed -i s,sys/xattr,attr/xattr, $TMPC&&  compile_prog "" "-lattr" ; then
> +  elif compile_prog "-DCONFIG_LIBATTR" "-lattr" ; then
>       attr=yes
>       LIBS="-lattr $LIBS"
>       libattr=yes