From: Anthony Liguori <anthony@codemonkey.ws>
To: Avi Kivity <avi@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Lucas Meneghel Rodrigues <lmr@redhat.com>,
KVM mailing list <kvm@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"libvir-list@redhat.com" <libvir-list@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
QEMU devel <qemu-devel@nongnu.org>,
Juan Jose Quintela Carreira <quintela@redhat.com>
Subject: Re: [Qemu-devel] qemu and qemu.git -> Migration + disk stress introduces qcow2 corruptions
Date: Sat, 12 Nov 2011 10:01:57 -0600 [thread overview]
Message-ID: <4EBE9875.6080505@codemonkey.ws> (raw)
In-Reply-To: <4EBE8623.5040705@redhat.com>
On 11/12/2011 08:43 AM, Avi Kivity wrote:
> On 11/12/2011 03:39 PM, Anthony Liguori wrote:
>> On 11/12/2011 04:27 AM, Avi Kivity wrote:
>>> On 11/11/2011 04:03 PM, Anthony Liguori wrote:
>>>>
>>>> I don't view not supporting migration with image formats as a
>>>> regression as it's never been a feature we've supported. While there
>>>> might be confusion about support around NFS, I think it's always been
>>>> clear that image formats cannot be used.
>>>
>>> Was there ever a statement to that effect? It was never clear to me and
>>> I doubt it was clear to anyone.
>>
>> You literally reviewed a patch who's subject was "block: allow
>> migration to work with image files"[1] that explained in gory detail
>> what the problem was.
>>
>> [1] http://mid.gmane.org/4C8CAD7C.5020102@redhat.com
>>
>
> Isn't a patch fixing a problem with migrating image files a statement
> that we do support migrating image files?
>
You know, we could go 9 rounds about this and it really doesn't matter.
For 1.0, I feel very strongly that we cannot change the semantics of migration
with raw as dramatically as has been proposed. That's a huge regression risk.
But since live migration with qcow2 has never worked, there's really not a lot
of harm of adding something that makes qcow2 with live migration work better
than it does right now.
I just sent out a series that does this. It's Kevin's original idea since
actually reopening the file doesn't help anything. The only thing that's
different from what I expect Kevin would want is that this is restricted to qcow2.
I want this restrict for 1.0. If once 1.1 opens up, Kevin wants to promote that
code to generic block layer code, that's fine with me.
It's also included as part of the migration blockers series so that we are very
explicit about when we don't support migration for given image formats.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2011-11-12 16:02 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 16:29 [Qemu-devel] qemu and qemu.git -> Migration + disk stress introduces qcow2 corruptions Lucas Meneghel Rodrigues
2011-11-09 16:39 ` Anthony Liguori
2011-11-09 17:02 ` Avi Kivity
2011-11-09 17:35 ` Anthony Liguori
2011-11-09 19:53 ` Juan Quintela
2011-11-09 20:18 ` Michael S. Tsirkin
2011-11-09 20:22 ` Anthony Liguori
2011-11-09 21:00 ` Michael S. Tsirkin
2011-11-09 21:01 ` Anthony Liguori
2011-11-10 10:41 ` Kevin Wolf
2011-11-10 16:50 ` Juan Quintela
2011-11-10 17:59 ` Anthony Liguori
2011-11-10 18:00 ` Anthony Liguori
2011-11-09 20:57 ` Juan Quintela
2011-11-10 8:55 ` Avi Kivity
2011-11-10 17:50 ` Juan Quintela
2011-11-10 17:54 ` Anthony Liguori
2011-11-12 10:20 ` Avi Kivity
2011-11-12 13:30 ` Anthony Liguori
2011-11-12 14:36 ` Avi Kivity
2011-11-10 18:27 ` Anthony Liguori
2011-11-10 18:42 ` Daniel P. Berrange
2011-11-10 19:11 ` Anthony Liguori
2011-11-10 20:06 ` Daniel P. Berrange
2011-11-10 20:07 ` Anthony Liguori
2011-11-10 21:30 ` Anthony Liguori
2011-11-11 10:15 ` Kevin Wolf
2011-11-11 14:03 ` Anthony Liguori
2011-11-11 14:29 ` Kevin Wolf
2011-11-11 14:35 ` Anthony Liguori
2011-11-11 14:44 ` Kevin Wolf
2011-11-11 20:38 ` Anthony Liguori
2011-11-12 10:27 ` Avi Kivity
2011-11-12 13:39 ` Anthony Liguori
2011-11-12 14:43 ` Avi Kivity
2011-11-12 16:01 ` Anthony Liguori [this message]
2011-11-12 10:25 ` Avi Kivity
2011-11-14 9:58 ` Kevin Wolf
2011-11-14 10:10 ` Michael S. Tsirkin
2011-11-15 13:28 ` Avi Kivity
2011-11-14 10:16 ` Daniel P. Berrange
2011-11-14 10:24 ` Michael S. Tsirkin
2011-11-14 11:08 ` Daniel P. Berrange
2011-11-14 11:21 ` Kevin Wolf
2011-11-14 11:29 ` Daniel P. Berrange
2011-11-14 11:34 ` Michael S. Tsirkin
2011-11-14 11:37 ` Daniel P. Berrange
2011-11-14 11:51 ` Michael S. Tsirkin
2011-11-14 11:55 ` Daniel P. Berrange
2011-11-14 11:56 ` Michael S. Tsirkin
2011-11-14 11:58 ` Daniel P. Berrange
2011-11-14 12:17 ` Michael S. Tsirkin
2011-11-14 11:36 ` Gleb Natapov
2011-11-14 11:32 ` Michael S. Tsirkin
2011-11-14 14:19 ` Anthony Liguori
2011-11-15 13:20 ` Juan Quintela
2011-11-15 13:56 ` Anthony Liguori
2011-11-09 19:25 ` Juan Quintela
2011-11-09 23:33 ` Lucas Meneghel Rodrigues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBE9875.6080505@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=libvir-list@redhat.com \
--cc=lmr@redhat.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).