From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55028) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RPsTs-0006Qb-6g for qemu-devel@nongnu.org; Mon, 14 Nov 2011 04:05:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RPsTr-0003Wp-3S for qemu-devel@nongnu.org; Mon, 14 Nov 2011 04:05:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27439) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RPsTq-0003We-Sb for qemu-devel@nongnu.org; Mon, 14 Nov 2011 04:05:31 -0500 Message-ID: <4EC0DA94.5000601@redhat.com> Date: Mon, 14 Nov 2011 10:08:36 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1321113420-3252-1-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1321113420-3252-1-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/7] migrate: add migration blockers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Lucas Meneghel Rodrigues , Stefan Hajnoczi , Juan Quintela , qemu-devel@nongnu.org, Avi Kivity Am 12.11.2011 16:56, schrieb Anthony Liguori: > This lets different subsystems register an Error that is thrown whenever > migration is attempted. This works nicely because it gracefully supports > things like hotplug. > > Right now, if multiple errors are registered, only one of them is reported. > I expect that for 1.1, we'll extend query-migrate to return all of the reasons > why migration is disabled at any given point in time. > > Signed-off-by: Anthony Liguori > Signed-off-by: Anthony Liguori > --- > migration.c | 18 ++++++++++++++++++ > migration.h | 15 +++++++++++++++ > 2 files changed, 33 insertions(+), 0 deletions(-) > > diff --git a/migration.c b/migration.c > index 41c3c24..6764d3a 100644 > --- a/migration.c > +++ b/migration.c > @@ -398,6 +398,18 @@ static MigrationState *migrate_init(Monitor *mon, int detach, int blk, int inc) > return s; > } > > +static GSList *migration_blockers; Any reason not to use qemu-queue.h? It's used everywhere else and being consistent is usually a good thing. If you want to switch to the glib functions as the standard for whatever reason, shouldn't we convert everything at once? Kevin