From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RPy7V-0002jT-JV for qemu-devel@nongnu.org; Mon, 14 Nov 2011 10:06:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RPy7U-0006Gg-7y for qemu-devel@nongnu.org; Mon, 14 Nov 2011 10:06:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:24191) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RPy7T-0006Gb-VB for qemu-devel@nongnu.org; Mon, 14 Nov 2011 10:06:48 -0500 Message-ID: <4EC12E82.9050605@redhat.com> Date: Mon, 14 Nov 2011 17:06:42 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1321281701-4192-1-git-send-email-avi@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1.0] configure: build position independent executables across the board, by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Blue Swirl , Paul Moore , qemu-devel@nongnu.org On 11/14/2011 05:00 PM, Peter Maydell wrote: > On 14 November 2011 14:59, Peter Maydell wrote: > > On 14 November 2011 14:41, Avi Kivity wrote: > >> +if test "$pie" = "yes" ; then > >> + QEMU_CFLAGS="-fPIE -DPIE $QEMU_CFLAGS" > >> + LDFLAGS="-Wl,-pie $LDFLAGS" > > > It would be good to see some testing that this works on all > > our random oddball hosts (MacOSX, for instance, which doesn't > > use GNU ld) and architectures we apply this... > > *before we apply this... We're unlikely to see testing before we apply the patch, and for oddball archs, even afterwards. What we can do the qualify it on a build test (and assume that if it builds, it runs, which I think is a safe assumption). -- error compiling committee.c: too many arguments to function