From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQ1DT-0005Ow-PX for qemu-devel@nongnu.org; Mon, 14 Nov 2011 13:25:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RQ1DS-0001NV-Gt for qemu-devel@nongnu.org; Mon, 14 Nov 2011 13:25:11 -0500 Received: from mail-gx0-f173.google.com ([209.85.161.173]:59225) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQ1DS-0001NP-Bv for qemu-devel@nongnu.org; Mon, 14 Nov 2011 13:25:10 -0500 Received: by ggnr4 with SMTP id r4so464874ggn.4 for ; Mon, 14 Nov 2011 10:25:09 -0800 (PST) Message-ID: <4EC15D02.1030007@codemonkey.ws> Date: Mon, 14 Nov 2011 12:25:06 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1321113420-3252-1-git-send-email-aliguori@us.ibm.com> <4EC0DA94.5000601@redhat.com> In-Reply-To: <4EC0DA94.5000601@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/7] migrate: add migration blockers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Lucas Meneghel Rodrigues , Anthony Liguori , Stefan Hajnoczi , Juan Quintela , qemu-devel@nongnu.org, Avi Kivity On 11/14/2011 03:08 AM, Kevin Wolf wrote: > Am 12.11.2011 16:56, schrieb Anthony Liguori: >> This lets different subsystems register an Error that is thrown whenever >> migration is attempted. This works nicely because it gracefully supports >> things like hotplug. >> >> Right now, if multiple errors are registered, only one of them is reported. >> I expect that for 1.1, we'll extend query-migrate to return all of the reasons >> why migration is disabled at any given point in time. >> >> Signed-off-by: Anthony Liguori >> Signed-off-by: Anthony Liguori >> --- >> migration.c | 18 ++++++++++++++++++ >> migration.h | 15 +++++++++++++++ >> 2 files changed, 33 insertions(+), 0 deletions(-) >> >> diff --git a/migration.c b/migration.c >> index 41c3c24..6764d3a 100644 >> --- a/migration.c >> +++ b/migration.c >> @@ -398,6 +398,18 @@ static MigrationState *migrate_init(Monitor *mon, int detach, int blk, int inc) >> return s; >> } >> >> +static GSList *migration_blockers; > > Any reason not to use qemu-queue.h? It's used everywhere else and being > consistent is usually a good thing. If you want to switch to the glib > functions as the standard for whatever reason, shouldn't we convert > everything at once? They're fundamentally different list implementations. GSList is a container while qemu-queues are embedded lists. In this case, it's impossible to use qemu-queue without creating another data structure which would make things more complex than they need to be. They aren't exact replacements for each other so I think they can co-exist and be used where they make sense respectively. Regards, Anthony Liguori > > Kevin >