From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53134) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQDfn-0005oE-GV for qemu-devel@nongnu.org; Tue, 15 Nov 2011 02:43:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RQDfm-0000Qt-7i for qemu-devel@nongnu.org; Tue, 15 Nov 2011 02:43:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:17631) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQDfl-0000Qh-WE for qemu-devel@nongnu.org; Tue, 15 Nov 2011 02:43:14 -0500 Message-ID: <4EC2180B.6050204@redhat.com> Date: Tue, 15 Nov 2011 09:43:07 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1321281701-4192-1-git-send-email-avi@redhat.com> <4EC12E82.9050605@redhat.com> <4EC13159.6070209@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1.0] configure: build position independent executables across the board, by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Blue Swirl , Paul Moore , qemu-devel@nongnu.org On 11/14/2011 08:45 PM, Peter Maydell wrote: > On 14 November 2011 15:18, Avi Kivity wrote: > > On 11/14/2011 05:15 PM, Peter Maydell wrote: > >> One of the failure cases I was thinking of is that if PIE means > >> the platform's loader puts things in a different bit of the > >> address space this might break TCG's assumptions about maximum > >> distances between the codegen buffer and host C code. (That's > >> a bug in TCG really but it would still be near-to-release > >> breakage.) > > And indeed testing this on an ARM host running i386 TCG system > mode, applying this patch causes qemu to fail at startup with > a tcg abort due to an out of range jump. > > I've already said that ARM is going to be broken for 1.0 so > that's not inherently a problem but it does indicate that > we definitely need to test the other TCG target systems > (and not just a "does it compile" test) if we want to put > this change in. I'll change the default to 'yes' for x86 hosts and 'no' for anything else. tcg host maintainers can then update after testing/modifications. -- error compiling committee.c: too many arguments to function