From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQHzn-0007ju-FH for qemu-devel@nongnu.org; Tue, 15 Nov 2011 07:20:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RQHzh-0003ff-DS for qemu-devel@nongnu.org; Tue, 15 Nov 2011 07:20:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:4148) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQHzh-0003eQ-06 for qemu-devel@nongnu.org; Tue, 15 Nov 2011 07:20:05 -0500 Message-ID: <4EC258F0.5090303@redhat.com> Date: Tue, 15 Nov 2011 14:20:00 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1321355644-1982-1-git-send-email-benoit.canet@gmail.com> In-Reply-To: <1321355644-1982-1-git-send-email-benoit.canet@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 00/14] Convert Sun devices to memory API. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org On 11/15/2011 01:13 PM, Beno=C3=AEt Canet wrote: > .valid was used where the access size is specified like in > http://www.ibiblio.org/pub/historic-linux/early-ports/Sparc/NCR/NCR89C1= 05.txt > .impl was used when the behavior is not known. Thanks, all applied except: > sun4c_intctl: convert to memory API > sun4m_iommu: convert to memory API Where we had raced - I just wrote those two conversions as well. As it happens, these were the only two patches that used .impl, which is a behaviour change; please avoid behaviour changes and do them as separate patches. Note I don't think .impl works well when .min_access_size =3D 4 - it requires RMW which we don't do yet. > esp: Fix memory API conversion > Thanks for that too. Will fold it into the bad patch. --=20 error compiling committee.c: too many arguments to function