qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Alon Levy <alevy@redhat.com>
Cc: avi@redhat.com, kraxel@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC 1.0] pc_piix: set qxl revision to 2 for pc-0.14
Date: Tue, 15 Nov 2011 09:04:32 -0600	[thread overview]
Message-ID: <4EC27F80.1050808@codemonkey.ws> (raw)
In-Reply-To: <1321190871-22769-1-git-send-email-alevy@redhat.com>

On 11/13/2011 07:27 AM, Alon Levy wrote:
> The default is still 3, and I didn't change older machine types.
>
> Signed-off-by: Alon Levy<alevy@redhat.com>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
> Is there a better way then copy pasting this to the older pc types to get
> the revision == 2 for them as well?
>
>   hw/pc_piix.c |   12 ++++++++++++
>   1 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/hw/pc_piix.c b/hw/pc_piix.c
> index 27ea570..970f43c 100644
> --- a/hw/pc_piix.c
> +++ b/hw/pc_piix.c
> @@ -311,6 +311,18 @@ static QEMUMachine pc_machine_v0_14 = {
>       .desc = "Standard PC",
>       .init = pc_init_pci,
>       .max_cpus = 255,
> +    .compat_props = (GlobalProperty[]) {
> +        {
> +            .driver   = "qxl",
> +            .property = "revision",
> +            .value    = stringify(2),
> +        },{
> +            .driver   = "qxl-vga",
> +            .property = "revision",
> +            .value    = stringify(2),
> +        },
> +        { /* end of list */ }
> +    },
>   };
>
>   static QEMUMachine pc_machine_v0_13 = {

      parent reply	other threads:[~2011-11-15 15:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-13 13:27 [Qemu-devel] [RFC 1.0] pc_piix: set qxl revision to 2 for pc-0.14 Alon Levy
2011-11-14 10:40 ` Gerd Hoffmann
2011-11-14 11:44   ` Alon Levy
2011-11-14 15:55     ` Gerd Hoffmann
2011-11-14 16:07       ` Anthony Liguori
2011-11-14 17:45         ` Avi Kivity
2011-11-14 17:48           ` Anthony Liguori
2011-11-14 17:51             ` Avi Kivity
2011-11-15 10:54               ` Gerd Hoffmann
2011-11-15 15:04 ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EC27F80.1050808@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=alevy@redhat.com \
    --cc=avi@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).