From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:60693)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RQKZ0-0004DR-06
	for qemu-devel@nongnu.org; Tue, 15 Nov 2011 10:04:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RQKYu-0007Et-Qb
	for qemu-devel@nongnu.org; Tue, 15 Nov 2011 10:04:41 -0500
Received: from mail-yx0-f173.google.com ([209.85.213.173]:56661)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RQKYu-0007Ep-Dp
	for qemu-devel@nongnu.org; Tue, 15 Nov 2011 10:04:36 -0500
Received: by yenr8 with SMTP id r8so7596172yen.4
	for <qemu-devel@nongnu.org>; Tue, 15 Nov 2011 07:04:36 -0800 (PST)
Message-ID: <4EC27F80.1050808@codemonkey.ws>
Date: Tue, 15 Nov 2011 09:04:32 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1321190871-22769-1-git-send-email-alevy@redhat.com>
In-Reply-To: <1321190871-22769-1-git-send-email-alevy@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC 1.0] pc_piix: set qxl revision to 2 for
	pc-0.14
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: avi@redhat.com, kraxel@redhat.com, qemu-devel@nongnu.org

On 11/13/2011 07:27 AM, Alon Levy wrote:
> The default is still 3, and I didn't change older machine types.
>
> Signed-off-by: Alon Levy<alevy@redhat.com>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
> Is there a better way then copy pasting this to the older pc types to get
> the revision == 2 for them as well?
>
>   hw/pc_piix.c |   12 ++++++++++++
>   1 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/hw/pc_piix.c b/hw/pc_piix.c
> index 27ea570..970f43c 100644
> --- a/hw/pc_piix.c
> +++ b/hw/pc_piix.c
> @@ -311,6 +311,18 @@ static QEMUMachine pc_machine_v0_14 = {
>       .desc = "Standard PC",
>       .init = pc_init_pci,
>       .max_cpus = 255,
> +    .compat_props = (GlobalProperty[]) {
> +        {
> +            .driver   = "qxl",
> +            .property = "revision",
> +            .value    = stringify(2),
> +        },{
> +            .driver   = "qxl-vga",
> +            .property = "revision",
> +            .value    = stringify(2),
> +        },
> +        { /* end of list */ }
> +    },
>   };
>
>   static QEMUMachine pc_machine_v0_13 = {