From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:43982)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <supriyak@linux.vnet.ibm.com>) id 1RQumv-0005mo-9I
	for qemu-devel@nongnu.org; Thu, 17 Nov 2011 00:45:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <supriyak@linux.vnet.ibm.com>) id 1RQumu-0003KO-1O
	for qemu-devel@nongnu.org; Thu, 17 Nov 2011 00:45:29 -0500
Received: from e23smtp06.au.ibm.com ([202.81.31.148]:34424)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <supriyak@linux.vnet.ibm.com>) id 1RQumt-0003JI-FY
	for qemu-devel@nongnu.org; Thu, 17 Nov 2011 00:45:27 -0500
Received: from /spool/local
	by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <supriyak@linux.vnet.ibm.com>;
	Thu, 17 Nov 2011 05:43:30 +1000
Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138])
	by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	pAH5g2Pg3362956
	for <qemu-devel@nongnu.org>; Thu, 17 Nov 2011 16:42:04 +1100
Received: from d23av02.au.ibm.com (loopback [127.0.0.1])
	by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	pAH5jAT2001518
	for <qemu-devel@nongnu.org>; Thu, 17 Nov 2011 16:45:10 +1100
Message-ID: <4EC49F62.9080903@linux.vnet.ibm.com>
Date: Thu, 17 Nov 2011 11:15:06 +0530
From: Supriya Kannery <supriyak@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <20111111064707.15024.69847.sendpatchset@skannery.in.ibm.com>
	<20111111064748.15024.14207.sendpatchset@skannery.in.ibm.com>
	<CAJSP0QWTOkit6Y=ATzWEV_ZEHpdrhwMMgj8y-A5hmyzeZ21D2Q@mail.gmail.com>
In-Reply-To: <CAJSP0QWTOkit6Y=ATzWEV_ZEHpdrhwMMgj8y-A5hmyzeZ21D2Q@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [v9 Patch 3/6]Qemu: Cmd "block_set_hostcache" for
 dynamic cache change
Reply-To: supriyak@linux.vnet.ibm.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org

On 11/17/2011 12:04 AM, Stefan Hajnoczi wrote:
> On Fri, Nov 11, 2011 at 6:47 AM, Supriya Kannery
> <supriyak@linux.vnet.ibm.com>  wrote:
>> +    {
>> +        .name       = "block_set_hostcache",
>> +        .args_type  = "device:B,option:b",
>> +        .params     = "device on|off",
>> +        .help       = "Change setting of host pagecache",
>> +        .user_print = monitor_user_noop,
>> +        .mhandler.cmd_new = do_block_set_hostcache,
>> +    },
>> +STEXI
>> +@item block_set_hostcache @var{device} @var{setting}
>
> @var{option}

Will send updated patch

>
>> +@findex block_set_hostcache
>> +Change host pagecache setting of a block device while guest is running.
>> +ETEXI
>> +
>>
>>      {
>>          .name       = "eject",
>> Index: qemu/qmp-commands.hx
>> ===================================================================
>> --- qemu.orig/qmp-commands.hx
>> +++ qemu/qmp-commands.hx
>> @@ -716,7 +716,34 @@ Example:
>>
>>   EQMP
>>
>> +
>>      {
>> +        .name       = "block_set_hostcache",
>> +        .args_type  = "device:B,option:b",
>> +        .params     = "device on|off",
>> +        .help       = "Change setting of host pagecache (true|false)",
>
> It would be more consistent to use "on|off" instead of "true|false".
> Or eliminate it entirely by saying "Enable or disable host pagecache
> usage".
>
> Stefan
>

Followed similar way how set_link is done.
Specified 'true/false' in brackets as 'on' or 'off' are not accepted as
bool parameter in qmp prompt.