qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Chunyan Liu <cyliu@suse.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V2] Add -f option to qemu-nbd
Date: Thu, 17 Nov 2011 14:41:35 +0100	[thread overview]
Message-ID: <4EC50F0F.3020400@redhat.com> (raw)
In-Reply-To: <1321529765-14863-1-git-send-email-cyliu@suse.com>

On 11/17/2011 12:36 PM, Chunyan Liu wrote:
>
> Adding lock to the nbd device before connecting disk image to that device to
> handling race conditions.

This removes the possibility for other programs to lock.  Have you 
checked what happens if you use the same device twice and whether you 
can piggyback on e.g. an EBUSY from the NBD_SET_SOCK ioctl?

Paolo

  reply	other threads:[~2011-11-17 13:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-17 11:36 [Qemu-devel] [PATCH V2] Add -f option to qemu-nbd Chunyan Liu
2011-11-17 13:41 ` Paolo Bonzini [this message]
2011-11-17 13:52   ` Stefan Hajnoczi
2011-11-18  1:25   ` Chun Yan Liu
2011-11-18  8:59     ` Paolo Bonzini
2011-11-23  6:51       ` Chun Yan Liu
2011-11-23  7:24         ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EC50F0F.3020400@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=cyliu@suse.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).