From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:60849)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <supriyak@in.ibm.com>) id 1RRL69-00006p-0D
	for qemu-devel@nongnu.org; Fri, 18 Nov 2011 04:51:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <supriyak@in.ibm.com>) id 1RRL67-00055H-Vv
	for qemu-devel@nongnu.org; Fri, 18 Nov 2011 04:51:04 -0500
Received: from e23smtp02.au.ibm.com ([202.81.31.144]:40931)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <supriyak@in.ibm.com>) id 1RRL67-00054p-DE
	for qemu-devel@nongnu.org; Fri, 18 Nov 2011 04:51:03 -0500
Received: from /spool/local
	by e23smtp02.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <supriyak@in.ibm.com>;
	Fri, 18 Nov 2011 09:37:19 +1000
Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139])
	by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	pAI9lTZB3424488
	for <qemu-devel@nongnu.org>; Fri, 18 Nov 2011 20:47:34 +1100
Received: from d23av04.au.ibm.com (loopback [127.0.0.1])
	by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	pAI9odcv029289
	for <qemu-devel@nongnu.org>; Fri, 18 Nov 2011 20:50:40 +1100
Message-ID: <4EC62584.70403@in.ibm.com>
Date: Fri, 18 Nov 2011 14:59:40 +0530
From: supriya kannery <supriyak@in.ibm.com>
MIME-Version: 1.0
References: <20111111064707.15024.69847.sendpatchset@skannery.in.ibm.com>
	<20111111064735.15024.68351.sendpatchset@skannery.in.ibm.com>
	<20111117105048.40ef4f9c@doriath>
In-Reply-To: <20111117105048.40ef4f9c@doriath>
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [v9 Patch 2/6]Qemu: Error classes for file reopen
 and data sync failure
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Supriya Kannery <supriyak@linux.vnet.ibm.com>, Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@gmail.com>

Luiz Capitulino wrote:
> On Fri, 11 Nov 2011 12:17:35 +0530
> Supriya Kannery <supriyak@linux.vnet.ibm.com> wrote:
>
>   
>> New error classes defined for file reopen failure and data
>> sync error
>>
>> Signed-off-by: Supriya Kannery <supriyak@linux.vnet.ibm.com>
>>
>> ---
>>  qerror.c |    8 ++++++++
>>  qerror.h |    6 ++++++
>>  2 files changed, 14 insertions(+)
>>
>> Index: qemu/qerror.c
>> ===================================================================
>> --- qemu.orig/qerror.c
>> +++ qemu/qerror.c
>> @@ -97,6 +97,14 @@ static const QErrorStringTable qerror_ta
>>          .desc      = "Device '%(device)' is not removable",
>>      },
>>      {
>> +        .error_fmt = QERR_DATA_SYNC_FAILED,
>> +        .desc      = "Syncing of data failed for device '%(device)'",
>> +    },
>> +    {
>> +        .error_fmt = QERR_REOPEN_FILE_FAILED,
>> +        .desc      = "Could not reopen '%(filename)'",
>> +    },
>>     
>
> Is this really needed? I think you could use QERR_OPEN_FILE_FAILED.
>
>   

This could confuse the user, as to what was tried on an
already opened file by qemu. So I feel, QERR_REOPEN_FILE_FAILED can
bring in better clarity to the message passed to the user.

- thanks Supriya