From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58927) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRNrR-0000cn-Jq for qemu-devel@nongnu.org; Fri, 18 Nov 2011 07:48:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RRNrP-0006jg-HF for qemu-devel@nongnu.org; Fri, 18 Nov 2011 07:48:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:28190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRNrP-0006ja-4q for qemu-devel@nongnu.org; Fri, 18 Nov 2011 07:48:03 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pAICm1hd028691 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 18 Nov 2011 07:48:02 -0500 Message-ID: <4EC654BD.2060208@redhat.com> Date: Fri, 18 Nov 2011 13:51:09 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1321355273-6139-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1321355273-6139-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio-blk: fix cross-endian config space List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, mst@redhat.com Am 15.11.2011 12:07, schrieb Paolo Bonzini: > Signed-off-by: Paolo Bonzini > --- > hw/virtio-blk.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c > index 01aeb28..4a15f0c 100644 > --- a/hw/virtio-blk.c > +++ b/hw/virtio-blk.c > @@ -481,14 +481,14 @@ static void virtio_blk_update_config(VirtIODevice *vdev, uint8_t *config) > stq_raw(&blkcfg.capacity, capacity); > stl_raw(&blkcfg.seg_max, 128 - 2); > stw_raw(&blkcfg.cylinders, cylinders); > + stl_raw(&blkcfg.blk_size, s->conf->logical_block_size); > + stw_raw(&blkcfg.min_io_size, s->conf->min_io_size / blkcfg.blk_size); > + stw_raw(&blkcfg.opt_io_size, s->conf->opt_io_size / blkcfg.blk_size); blkcfg.blk_size is in target endianness now, so you can't use it in the calculation for min/opt_io_size any more. Kevin