From: "Andreas Färber" <afaerber@suse.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1.0 v2] scsi: fix fw path
Date: Fri, 18 Nov 2011 14:36:24 +0100 [thread overview]
Message-ID: <4EC65F58.6060500@suse.de> (raw)
In-Reply-To: <4EC65126.9000206@redhat.com>
Am 18.11.2011 13:35, schrieb Kevin Wolf:
> Am 15.11.2011 17:36, schrieb Paolo Bonzini:
>> The pre-1.0 firmware path for SCSI devices already included the LUN
>> using the suffix argument to add_boot_device_path. I missed that when
>> making channel and LUN customizable. Avoid that it is included twice, and
>> convert the colons to commas for consistency with other kinds of devices
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> v1->v2: include scsi-disk hunk too
>
> Thanks, applied to the block-stable branch (for 1.0)
Did you guys check the consistency part against OpenFirmware syntax? I
didn't get around to that yet.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2011-11-18 13:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 13:28 [Qemu-devel] [PATCH 1.0] scsi: fix fw path Paolo Bonzini
2011-11-15 16:36 ` [Qemu-devel] [PATCH 1.0 v2] " Paolo Bonzini
2011-11-18 12:35 ` Kevin Wolf
2011-11-18 13:36 ` Andreas Färber [this message]
2011-11-18 13:59 ` Paolo Bonzini
2011-11-18 14:10 ` Kevin Wolf
2011-11-18 14:07 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC65F58.6060500@suse.de \
--to=afaerber@suse.de \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).