From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50944) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RROcY-0003BQ-4M for qemu-devel@nongnu.org; Fri, 18 Nov 2011 08:36:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RROcX-00073V-1Z for qemu-devel@nongnu.org; Fri, 18 Nov 2011 08:36:46 -0500 Received: from cantor2.suse.de ([195.135.220.15]:51061 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RROcW-00073R-Rx for qemu-devel@nongnu.org; Fri, 18 Nov 2011 08:36:45 -0500 Message-ID: <4EC65F58.6060500@suse.de> Date: Fri, 18 Nov 2011 14:36:24 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1321363722-23687-1-git-send-email-pbonzini@redhat.com> <1321374998-18214-1-git-send-email-pbonzini@redhat.com> <4EC65126.9000206@redhat.com> In-Reply-To: <4EC65126.9000206@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1.0 v2] scsi: fix fw path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Paolo Bonzini , qemu-devel@nongnu.org Am 18.11.2011 13:35, schrieb Kevin Wolf: > Am 15.11.2011 17:36, schrieb Paolo Bonzini: >> The pre-1.0 firmware path for SCSI devices already included the LUN >> using the suffix argument to add_boot_device_path. I missed that when >> making channel and LUN customizable. Avoid that it is included twice,= and >> convert the colons to commas for consistency with other kinds of devic= es >> >> Signed-off-by: Paolo Bonzini >> --- >> v1->v2: include scsi-disk hunk too >=20 > Thanks, applied to the block-stable branch (for 1.0) Did you guys check the consistency part against OpenFirmware syntax? I didn't get around to that yet. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg