From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:56667)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1RRRlW-0004yK-52
	for qemu-devel@nongnu.org; Fri, 18 Nov 2011 11:58:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1RRRlR-0007LL-WC
	for qemu-devel@nongnu.org; Fri, 18 Nov 2011 11:58:14 -0500
Received: from mx1.redhat.com ([209.132.183.28]:16576)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1RRRlR-0007LF-Nw
	for qemu-devel@nongnu.org; Fri, 18 Nov 2011 11:58:09 -0500
Message-ID: <4EC68F5B.9020200@redhat.com>
Date: Fri, 18 Nov 2011 18:01:15 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1321542834-6880-1-git-send-email-kwolf@redhat.com>
	<1321542834-6880-9-git-send-email-kwolf@redhat.com>
	<CAJSP0QWhxTxSe2GRX_ZNVhJaDLxxajShT5rXsTh0O_O-fiZdNA@mail.gmail.com>
In-Reply-To: <CAJSP0QWhxTxSe2GRX_ZNVhJaDLxxajShT5rXsTh0O_O-fiZdNA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 8/8] qcow2: Fix error path in
	qcow2_snapshot_load_tmp
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org

Am 18.11.2011 17:45, schrieb Stefan Hajnoczi:
> On Thu, Nov 17, 2011 at 3:13 PM, Kevin Wolf <kwolf@redhat.com> wrote:
>> +    s->l1_table = new_l1_table;
>> +    g_free(s->l1_table);
> 
> O_o .oO( immediately frees new_l1_table?! )

This was just a test to see if you're still awake at patch 8.

*cough*

Ok, I guess you found the patch that I forgot to test...

Kevin