From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50134) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSTId-0008A6-Qc for qemu-devel@nongnu.org; Mon, 21 Nov 2011 07:48:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RSTIY-0007YF-BP for qemu-devel@nongnu.org; Mon, 21 Nov 2011 07:48:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSTIY-0007Xc-3o for qemu-devel@nongnu.org; Mon, 21 Nov 2011 07:48:34 -0500 Message-ID: <4ECA489A.7040108@redhat.com> Date: Mon, 21 Nov 2011 13:48:26 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1321607573-29744-1-git-send-email-zhihuili@linux.vnet.ibm.com> <4ECA2B78.7040400@redhat.com> <4ECA3115.9040208@redhat.com> In-Reply-To: <4ECA3115.9040208@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block: Use bdrv functions to replace file operation in qcow.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Stefan Hajnoczi , qemu-devel@nongnu.org On 11/21/2011 12:08 PM, Kevin Wolf wrote: > I didn't say this.:-) > > At least in theory, block devices may not be the only protocols with > !has_zero_init. We have only covered raw-posix with this discussion. I > would prefer an explicit write of the table to avoid breaking other > protocols (though I don't think we have one today; curl would be a > candidate, but it is read-only). Indeed, I'm also fine with the patch. Paolo