From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38853) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSTzp-00078d-JO for qemu-devel@nongnu.org; Mon, 21 Nov 2011 08:33:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RSTzl-0007YI-R4 for qemu-devel@nongnu.org; Mon, 21 Nov 2011 08:33:17 -0500 Message-ID: <4ECA52E8.6050801@web.de> Date: Mon, 21 Nov 2011 14:32:24 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1321730319-21498-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1321730319-21498-1-git-send-email-sw@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] darwin-user: Fix format string in debug message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Am 19.11.2011 20:18, schrieb Stefan Weil: > This was spotted by cppcheck. > > Signed-off-by: Stefan Weil > --- > darwin-user/signal.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/darwin-user/signal.c b/darwin-user/signal.c > index c530227..317ef92 100644 > --- a/darwin-user/signal.c > +++ b/darwin-user/signal.c > @@ -270,8 +270,7 @@ int do_sigaction(int sig, const struct sigaction *act, > host_sig = target_to_host_signal(sig); > if (host_sig != SIGSEGV && host_sig != SIGBUS) { > #if defined(DEBUG_SIGNAL) > - fprintf(stderr, "sigaction handler going to call sigaction\n", > - act->sa_handler, act->sa_flags, act->sa_mask); > + fprintf(stderr, "sigaction handler going to call sigaction\n"); > #endif > > sigfillset(&act1.sa_mask); Is the debug output really useful without the information? Maybe rather append %p %x %x? What does linux-user do? Andreas