From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:40895)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RSYIt-0002Ud-IU
	for qemu-devel@nongnu.org; Mon, 21 Nov 2011 13:09:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RSYIp-0000c4-NY
	for qemu-devel@nongnu.org; Mon, 21 Nov 2011 13:09:15 -0500
Received: from cantor2.suse.de ([195.135.220.15]:53738 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RSYIp-0000bw-Ec
	for qemu-devel@nongnu.org; Mon, 21 Nov 2011 13:09:11 -0500
Message-ID: <4ECA93A9.4090301@suse.de>
Date: Mon, 21 Nov 2011 19:08:41 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1321895345-27959-1-git-send-email-lcapitulino@redhat.com>
	<1321895345-27959-2-git-send-email-lcapitulino@redhat.com>
In-Reply-To: <1321895345-27959-2-git-send-email-lcapitulino@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/4] configure: Don't mix glib and libcheck
 tests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com

Am 21.11.2011 18:09, schrieb Luiz Capitulino:
> test-coroutine is listed as a libcheck test in the 'checks' variable. T=
his
> is not right because 'make check' won't run test-coroutine if libcheck
> tests are not enabled (either because libcheck isn't detected or becaus=
e
> --disable-check-utests is passed).
>=20
> Tests using the glib test framework are independent from libcheck and
> afaik are always present (although having a configure switch to disable
> them is probably worth it).
>=20
> Untagle test-coroutine from the libcheck tests by introducing the

Untangle

> 'test_progs' variable and using it to generate the test list used by
> 'make check'.
>=20
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>

Reviewed-by: Andreas F=E4rber <afaerber@suse.de>

Andreas

> ---
>  configure |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>=20
> diff --git a/configure b/configure
> index 6c77fbb..ac0fbd9 100755
> --- a/configure
> +++ b/configure
> @@ -2685,8 +2685,9 @@ if test "$softmmu" =3D yes ; then
>      fi
>      if [ "$check_utests" =3D "yes" ]; then
>        checks=3D"check-qint check-qstring check-qdict check-qlist"
> -      checks=3D"check-qfloat check-qjson test-coroutine $checks"
> +      checks=3D"check-qfloat check-qjson $checks"
>      fi
> +    test_progs=3D"$checks test-coroutine"
>    fi
>  fi
> =20
> @@ -3175,7 +3176,7 @@ if test "$trace_default" =3D "yes"; then
>  fi
> =20
>  echo "TOOLS=3D$tools" >> $config_host_mak
> -echo "CHECKS=3D$checks" >> $config_host_mak
> +echo "CHECKS=3D$test_progs" >> $config_host_mak
>  echo "ROMS=3D$roms" >> $config_host_mak
>  echo "MAKE=3D$make" >> $config_host_mak
>  echo "INSTALL=3D$install" >> $config_host_mak


--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg