From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSe5t-0005O8-CR for qemu-devel@nongnu.org; Mon, 21 Nov 2011 19:20:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RSe5p-0002lO-DV for qemu-devel@nongnu.org; Mon, 21 Nov 2011 19:20:13 -0500 Received: from mail-gy0-f173.google.com ([209.85.160.173]:50530) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSe5p-0002ky-7U for qemu-devel@nongnu.org; Mon, 21 Nov 2011 19:20:09 -0500 Received: by ghbg19 with SMTP id g19so3013857ghb.4 for ; Mon, 21 Nov 2011 16:20:08 -0800 (PST) Message-ID: <4ECAEAB2.3090702@codemonkey.ws> Date: Mon, 21 Nov 2011 18:20:02 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1321892148-16835-1-git-send-email-kraxel@redhat.com> In-Reply-To: <1321892148-16835-1-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL v2 1.0] usb patch queue List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On 11/21/2011 10:15 AM, Gerd Hoffmann wrote: > Hi, > > This pull fixes SYNCRONIZE_CACHE handling in usb-storage code. > > The SYNCRONIZE_CACHE scsi command is different from all other ones: > It doesn't transfer any data, but still doesn't complete instantly. > usb-storage failes to handle this case correctly, resulting in all sorts > of funky assert failures and segfaults when the guest writes to a > virtual usb stick and flushes stuff. > > Patches 1-4 are minor cleanups for usb-storage (slighly improved scsi > request tracking). Patch 5 is the actual bugfix, which depends on the > cleanups. > > Patches 6+7 are bonus fixes for Coverity-spotted issues which are > sitting in the usb patch queue for a while already. Pulled. Thanks. Regards, Anthony Liguori > > The following changes since commit bc4268998d154b9b3cc86a7b6bd932cc974591c9: > > x86: fix pcmpestrm and pcmpistrm (2011-11-19 13:51:27 +0000) > > are available in the git repository at: > git://git.kraxel.org/qemu usb.31 > > Gerd Hoffmann (7): > usb-storage: move status debug message to usb_msd_send_status. > usb-storage: fill status in complete callback. > usb-storage: drop tag from device state. > usb-storage: drop result from device state. > usb-storage: don't try to send the status early. > ehci: add assert > usb-linux: fix /proc/bus/usb/devices scan > > hw/usb-ehci.c | 1 + > hw/usb-msd.c | 65 ++++++++++++++++++++++++++++++-------------------------- > usb-linux.c | 7 +++++- > 3 files changed, 42 insertions(+), 31 deletions(-) > >