From: Anthony Liguori <anthony@codemonkey.ws>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Include zlib.h using #include <>
Date: Mon, 21 Nov 2011 18:22:02 -0600 [thread overview]
Message-ID: <4ECAEB2A.8010201@codemonkey.ws> (raw)
In-Reply-To: <1321788870-27848-1-git-send-email-sw@weilnetz.de>
On 11/20/2011 05:34 AM, Stefan Weil wrote:
> zlib.h is not a local include file, therefore it should be included
> using<> instead of "".
>
> Signed-off-by: Stefan Weil<sw@weilnetz.de>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> block/vmdk.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/block/vmdk.c b/block/vmdk.c
> index e53a2f0..96f7d5d 100644
> --- a/block/vmdk.c
> +++ b/block/vmdk.c
> @@ -26,7 +26,7 @@
> #include "qemu-common.h"
> #include "block_int.h"
> #include "module.h"
> -#include "zlib.h"
> +#include<zlib.h>
>
> #define VMDK3_MAGIC (('C'<< 24) | ('O'<< 16) | ('W'<< 8) | 'D')
> #define VMDK4_MAGIC (('K'<< 24) | ('D'<< 16) | ('M'<< 8) | 'V')
prev parent reply other threads:[~2011-11-22 0:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-20 11:34 [Qemu-devel] [PATCH] Include zlib.h using #include <> Stefan Weil
2011-11-22 0:22 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECAEB2A.8010201@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).