From: "Cao,Bing Bu" <mars@linux.vnet.ibm.com>
To: armbru@redhat.com, pbonzini@redhat.com
Cc: "Cao, Bing Bu" <mars@linux.vnet.ibm.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH][V2] Can't screendump without a console
Date: Tue, 22 Nov 2011 09:26:21 +0800 [thread overview]
Message-ID: <4ECAFA3D.90309@linux.vnet.ibm.com> (raw)
In-Reply-To: <4EC8DE54.20802@redhat.com>
When usinge "-vga none -nographic" option.
There is no any text and graphic console created in this case.
screen dump not supported without console.
Signed-off-by: Cao,Bing Bu <mars@linux.vnet.ibm.com>
---
console.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/console.c b/console.c
index f6fe441..6071ef3 100644
--- a/console.c
+++ b/console.c
@@ -184,8 +184,10 @@ void vga_hw_screen_dump(const char *filename)
console_select(0);
if (consoles[0] && consoles[0]->hw_screen_dump) {
consoles[0]->hw_screen_dump(consoles[0]->hw, filename);
+ } else {
+ error_printf("no any console,could not screen dump \n");
+ return;
}
-
console_select(previous_active_console->index);
}
--
1.7.1
next prev parent reply other threads:[~2011-11-22 1:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 15:47 [Qemu-devel] [PATCH] console: Fix segfault on screendump without VGA adapter Alexander Graf
2011-11-20 9:31 ` [Qemu-devel] [PATCH] creen dump not supported when no console Cao,Bing Bu
2011-11-20 11:02 ` Paolo Bonzini
2011-11-22 1:26 ` Cao,Bing Bu [this message]
2011-11-21 12:30 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECAFA3D.90309@linux.vnet.ibm.com \
--to=mars@linux.vnet.ibm.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).