From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel <qemu-devel@nongnu.org>,
Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH 1.0] 9pfs: improve portability to older systems
Date: Tue, 22 Nov 2011 08:36:08 +0100 [thread overview]
Message-ID: <4ECB50E8.7010502@redhat.com> (raw)
In-Reply-To: <4ECABC30.6030602@codemonkey.ws>
On 11/21/2011 10:01 PM, Anthony Liguori wrote:
>>
>> - return qemu_utimensat(AT_FDCWD, rpath(s, path, buffer), buf,
>> - AT_SYMLINK_NOFOLLOW);
>> + return qemu_utimens(rpath(s, path, buffer), buf);
>
> Hrm, I thought the SYMLINK_NOFOLLOW was critical in enforcing security?
Yes, and it is applied by qemu_utimens automatically (but the constant
only appears in a section where we know it is defined).
Paolo
next prev parent reply other threads:[~2011-11-22 7:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 8:29 [Qemu-devel] [PATCH 1.0] 9pfs: improve portability to older systems Paolo Bonzini
2011-11-21 21:01 ` Anthony Liguori
2011-11-22 7:36 ` Paolo Bonzini [this message]
2011-11-23 6:16 ` Aneesh Kumar K.V
2011-11-23 7:24 ` Paolo Bonzini
2011-11-23 15:11 ` Aneesh Kumar K.V
2011-11-23 15:23 ` Paolo Bonzini
2011-11-28 22:36 ` Anthony Liguori
2011-11-29 8:45 ` Paolo Bonzini
2011-11-30 21:27 ` Erik Rull
2011-12-01 9:03 ` Paolo Bonzini
2011-12-03 11:35 ` Erik Rull
2011-12-03 11:35 ` Erik Rull
2011-11-29 9:43 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECB50E8.7010502@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).