From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSktq-0003nV-60 for qemu-devel@nongnu.org; Tue, 22 Nov 2011 02:36:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RSktp-0005A3-6o for qemu-devel@nongnu.org; Tue, 22 Nov 2011 02:36:14 -0500 Received: from mail-ww0-f53.google.com ([74.125.82.53]:36138) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSktp-00059w-1K for qemu-devel@nongnu.org; Tue, 22 Nov 2011 02:36:13 -0500 Received: by wwf27 with SMTP id 27so10597413wwf.10 for ; Mon, 21 Nov 2011 23:36:12 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4ECB50E8.7010502@redhat.com> Date: Tue, 22 Nov 2011 08:36:08 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1321864151-13988-1-git-send-email-pbonzini@redhat.com> <4ECABC30.6030602@codemonkey.ws> In-Reply-To: <4ECABC30.6030602@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1.0] 9pfs: improve portability to older systems List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel , Anthony Liguori On 11/21/2011 10:01 PM, Anthony Liguori wrote: >> >> - return qemu_utimensat(AT_FDCWD, rpath(s, path, buffer), buf, >> - AT_SYMLINK_NOFOLLOW); >> + return qemu_utimens(rpath(s, path, buffer), buf); > > Hrm, I thought the SYMLINK_NOFOLLOW was critical in enforcing security? Yes, and it is applied by qemu_utimens automatically (but the constant only appears in a section where we know it is defined). Paolo