From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 5/9] qcow2: Rework qcow2_snapshot_create error handling
Date: Tue, 22 Nov 2011 10:14:43 +0100 [thread overview]
Message-ID: <4ECB6803.3070305@redhat.com> (raw)
In-Reply-To: <CAJSP0QVp4G1pdDoQuEtP5E3VWTKfTXxaGTCByJTbKhh-Eq-SuA@mail.gmail.com>
Am 21.11.2011 17:47, schrieb Stefan Hajnoczi:
> On Fri, Nov 18, 2011 at 6:29 PM, Kevin Wolf <kwolf@redhat.com> wrote:
>> + /*
>> + * Increase the refcounts of all clusters and make sure everything is
>> + * stable on disk before updating the snapshot table to contain a pointer
>> + * to the new L1 table.
>> + */
>> + ret = qcow2_update_snapshot_refcount(bs, s->l1_table_offset, s->l1_size, 1);
>> + if (ret < 0) {
>> + goto fail;
>> + }
>> +
>> + ret = bdrv_flush(bs->file);
>
> Do we need to explicitly flush the qcow2 cache to ensure metadata
> reaches the disk?
Yes, I think this should be a bdrv_flush(bs). I'm not completely sure if
it is really required, but I couldn't immediately tell why it's safe and
this isn't a fast path anyway, so I'll replace this before merging the
series (won't send out a v3 for this).
Kevin
next prev parent reply other threads:[~2011-11-22 9:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 18:28 [Qemu-devel] [PATCH v2 0/9] qcow2: Fix error paths for internal snapshots Kevin Wolf
2011-11-18 18:28 ` [Qemu-devel] [PATCH v2 1/9] qcow2: Return real error code in qcow2_read_snapshots Kevin Wolf
2011-11-18 18:28 ` [Qemu-devel] [PATCH v2 2/9] qcow2: Return real error code in qcow2_write_snapshots Kevin Wolf
2011-11-18 18:28 ` [Qemu-devel] [PATCH v2 3/9] qcow2: Update snapshot table information at once Kevin Wolf
2011-11-18 18:29 ` [Qemu-devel] [PATCH v2 4/9] qcow2: Cleanups and memleak fix in qcow2_snapshot_create Kevin Wolf
2011-11-18 18:29 ` [Qemu-devel] [PATCH v2 5/9] qcow2: Rework qcow2_snapshot_create error handling Kevin Wolf
2011-11-21 16:47 ` Stefan Hajnoczi
2011-11-22 9:14 ` Kevin Wolf [this message]
2011-11-22 9:45 ` Stefan Hajnoczi
2011-11-18 18:29 ` [Qemu-devel] [PATCH v2 6/9] qcow2: Return real error in qcow2_snapshot_goto Kevin Wolf
2011-11-18 18:29 ` [Qemu-devel] [PATCH v2 7/9] qcow2: Fix order of refcount updates " Kevin Wolf
2011-11-18 18:29 ` [Qemu-devel] [PATCH v2 8/9] qcow2: Fix order in qcow2_snapshot_delete Kevin Wolf
2011-11-18 18:29 ` [Qemu-devel] [PATCH v2 9/9] qcow2: Fix error path in qcow2_snapshot_load_tmp Kevin Wolf
2011-11-21 16:58 ` [Qemu-devel] [PATCH v2 0/9] qcow2: Fix error paths for internal snapshots Stefan Hajnoczi
2011-11-22 14:12 ` Kevin Wolf
2011-11-22 14:21 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECB6803.3070305@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).