From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSoWd-0001U8-CJ for qemu-devel@nongnu.org; Tue, 22 Nov 2011 06:28:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RSoWc-0004o0-Hm for qemu-devel@nongnu.org; Tue, 22 Nov 2011 06:28:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40510) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSoWc-0004nl-7U for qemu-devel@nongnu.org; Tue, 22 Nov 2011 06:28:30 -0500 Message-ID: <4ECB87F5.1070908@redhat.com> Date: Tue, 22 Nov 2011 12:31:01 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <20111111064707.15024.69847.sendpatchset@skannery.in.ibm.com> <20111111064802.15024.83662.sendpatchset@skannery.in.ibm.com> <4EC4991C.1070306@linux.vnet.ibm.com> <4ECA43F2.7080506@in.ibm.com> <4ECB590D.2090602@in.ibm.com> <4ECB71A0.3090703@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [v9 Patch 4/6]Qemu: Add commandline -drive option 'hostcache' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, supriyak@linux.vnet.ibm.com, Luiz Capitulino , Christoph Hellwig , supriya kannery Am 22.11.2011 12:17, schrieb Stefan Hajnoczi: > On Tue, Nov 22, 2011 at 9:55 AM, Kevin Wolf wrote: >> Am 22.11.2011 09:10, schrieb supriya kannery: >>> Let us have the implementation for hostcache= as command line option, with >>> the condition that if both cache= and hostcache= are specified together, >>> then depending upon enable/disable value specified for hostcache, >>> corresponding >>> bit in cache flags can be set/reset. That way, there is a value add on >>> specifying >>> hostcache in cmdline as well as user will be able to control hostcache >>> value from cmdline >>> itself. >> >> The additional thing this would introduce is cache=unsafe hostcache=off. >> Probably not the most common thing to have, but why not allow it now. > > QEMU's command-line is hairy enough already. I don't think this > option is helpful until we can replace cache= completely. > > This is a subjective issue though so if you want to take this option, > Kevin, then please do. In fact, I think I suggested removing it in an earlier version of the series because I felt the same. I didn't have a strong enough opinion on it to really insist on it, though. Discuss it with Supriya and I'll be happy with whatever you decide. Kevin