From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:43029)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RSpNr-00035c-8C
	for qemu-devel@nongnu.org; Tue, 22 Nov 2011 07:23:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RSpNq-000091-09
	for qemu-devel@nongnu.org; Tue, 22 Nov 2011 07:23:31 -0500
Received: from mx1.redhat.com ([209.132.183.28]:32179)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1RSpNp-00008t-PW
	for qemu-devel@nongnu.org; Tue, 22 Nov 2011 07:23:29 -0500
Message-ID: <4ECB943D.9050909@redhat.com>
Date: Tue, 22 Nov 2011 13:23:25 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1320159390-29797-1-git-send-email-kraxel@redhat.com>
	<1320159390-29797-2-git-send-email-kraxel@redhat.com>
	<4EBB48D3.8030404@linux.vnet.ibm.com>
In-Reply-To: <4EBB48D3.8030404@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/3] usb-hub: wakeup on attach
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: hkran <hkran@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org

  Hi,

> After I add usb_wake like this in the function usb_hub_detach. the
> problem can be fixed.
> 
> static void usb_hub_detach(USBPort *port1)
> {
>     USBHubState *s = port1->opaque;
>     USBHubPort *port = &s->ports[port1->index];
> 
>     usb_wakeup(&s->dev);                
> ---------------------------------->wakeup when detach

Fix added to usb patch queue.

thanks,
  Gerd