From: Avi Kivity <avi@redhat.com>
To: "Benoît Canet" <benoit.canet@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 06/11] lm32_sys: convert to memory API
Date: Tue, 22 Nov 2011 19:36:56 +0200 [thread overview]
Message-ID: <4ECBDDB8.3000009@redhat.com> (raw)
In-Reply-To: <1321979527-23921-7-git-send-email-benoit.canet@gmail.com>
On 11/22/2011 06:32 PM, Benoît Canet wrote:
>
> -static CPUReadMemoryFunc * const sys_read_fn[] = {
> - NULL,
> - NULL,
> - NULL,
> -};
> -
> -static CPUWriteMemoryFunc * const sys_write_fn[] = {
> - NULL,
> - NULL,
> - &sys_write,
> +static const MemoryRegionOps sys_ops = {
> + .old_mmio = {
> + .read = { NULL, NULL, NULL, },
> + .write = { NULL, NULL, sys_write, },
> + },
> + .endianness = DEVICE_NATIVE_ENDIAN,
> };
Please use .valid.accepts for cases like this.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-11-22 17:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 16:31 [Qemu-devel] [PATCH v2 00/11] more memory API conversion Benoît Canet
2011-11-22 16:31 ` [Qemu-devel] [PATCH v2 01/11] mcf5206: convert to memory API Benoît Canet
2011-11-22 16:31 ` [Qemu-devel] [PATCH v2 02/11] mcf_uart: " Benoît Canet
2011-11-22 16:31 ` [Qemu-devel] [PATCH v2 03/11] mcf_fec: " Benoît Canet
2011-11-22 16:32 ` [Qemu-devel] [PATCH v2 04/11] mcf_intc: " Benoît Canet
2011-11-22 16:32 ` [Qemu-devel] [PATCH v2 05/11] lm32_uart: " Benoît Canet
2011-11-22 16:32 ` [Qemu-devel] [PATCH v2 06/11] lm32_sys: " Benoît Canet
2011-11-22 17:36 ` Avi Kivity [this message]
2011-11-22 16:32 ` [Qemu-devel] [PATCH v2 07/11] bonito: convert north bridge register mapping " Benoît Canet
2011-11-22 16:32 ` [Qemu-devel] [PATCH v2 08/11] bonito: convert north bridge pci config " Benoît Canet
2011-11-22 16:32 ` [Qemu-devel] [PATCH v2 09/11] bonito: convert south " Benoît Canet
2011-11-22 16:32 ` [Qemu-devel] [PATCH v2 10/11] bonito: convert ldma " Benoît Canet
2011-11-22 16:32 ` [Qemu-devel] [PATCH v2 11/11] bonito: convert cop " Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECBDDB8.3000009@redhat.com \
--to=avi@redhat.com \
--cc=benoit.canet@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).