From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:52402)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1RSuHI-0000kF-VU
	for qemu-devel@nongnu.org; Tue, 22 Nov 2011 12:37:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1RSuHE-0000xD-Qu
	for qemu-devel@nongnu.org; Tue, 22 Nov 2011 12:37:04 -0500
Received: from mx1.redhat.com ([209.132.183.28]:31222)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1RSuHE-0000x5-JO
	for qemu-devel@nongnu.org; Tue, 22 Nov 2011 12:37:00 -0500
Message-ID: <4ECBDDB8.3000009@redhat.com>
Date: Tue, 22 Nov 2011 19:36:56 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1321979527-23921-1-git-send-email-benoit.canet@gmail.com>
	<1321979527-23921-7-git-send-email-benoit.canet@gmail.com>
In-Reply-To: <1321979527-23921-7-git-send-email-benoit.canet@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 06/11] lm32_sys: convert to memory API
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= <benoit.canet@gmail.com>
Cc: qemu-devel@nongnu.org

On 11/22/2011 06:32 PM, Beno=C3=AEt Canet wrote:
> =20
> -static CPUReadMemoryFunc * const sys_read_fn[] =3D {
> -    NULL,
> -    NULL,
> -    NULL,
> -};
> -
> -static CPUWriteMemoryFunc * const sys_write_fn[] =3D {
> -    NULL,
> -    NULL,
> -    &sys_write,
> +static const MemoryRegionOps sys_ops =3D {
> +    .old_mmio =3D {
> +        .read =3D { NULL, NULL, NULL, },
> +        .write =3D { NULL, NULL, sys_write, },
> +    },
> +    .endianness =3D DEVICE_NATIVE_ENDIAN,
>  };

Please use .valid.accepts for cases like this.

--=20
error compiling committee.c: too many arguments to function