From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54838)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1RTCiH-0003lj-Nn
	for qemu-devel@nongnu.org; Wed, 23 Nov 2011 08:18:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1RTCiG-0005HY-M1
	for qemu-devel@nongnu.org; Wed, 23 Nov 2011 08:18:09 -0500
Received: from cantor2.suse.de ([195.135.220.15]:57559 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1RTCiG-0005HB-HL
	for qemu-devel@nongnu.org; Wed, 23 Nov 2011 08:18:08 -0500
Message-ID: <4ECCF2C0.4010801@suse.de>
Date: Wed, 23 Nov 2011 14:18:56 +0100
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1321878079-30836-1-git-send-email-peter.maydell@linaro.org>
	<20111123131525.GA11085@afflict.kos.to>
In-Reply-To: <20111123131525.GA11085@afflict.kos.to>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] linux-user/strace.c: Correct errno
 printing for mmap etc
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Riku Voipio <riku.voipio@iki.fi>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, patches@linaro.org

On 11/23/2011 02:15 PM, Riku Voipio wrote:
> On Mon, Nov 21, 2011 at 12:21:19PM +0000, Peter Maydell wrote:
>> Correct the printing of errnos for syscalls which are handled
>> via print_syscall_ret_addr (mmap, mmap2, brk, shmat): errnos
>> are returned as negative returned values at this level, not
>> via the host 'errno' variable.
>
>> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
>> ---
>> This applies on top of Alex's [v3] linux-user: fix QEMU_STRACE=1 segfault
>> patch. It is fixing a separate bug to that patch, but OTOH it does touch
>> only four lines of actual code, all of which were added in that patch.
>> Keep it separate or fold it in with that one, I don't mind.
> I think in general it is recommended to squash patches that only change lines
> added in the previous patch. Otoh it muddies the authorship of the change.
> Thus, unless someone objects, I'll que these as separate patches so both
> of you get clear credit.

I am completely indifferent :).


Alex