From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RTEgV-0005Zx-64 for qemu-devel@nongnu.org; Wed, 23 Nov 2011 10:24:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RTEgN-0007rO-8s for qemu-devel@nongnu.org; Wed, 23 Nov 2011 10:24:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:24627) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RTEgM-0007rB-TN for qemu-devel@nongnu.org; Wed, 23 Nov 2011 10:24:19 -0500 Message-ID: <4ECD0FEE.7030808@redhat.com> Date: Wed, 23 Nov 2011 16:23:26 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1321864151-13988-1-git-send-email-pbonzini@redhat.com> <8762ibl5xg.fsf@linux.vnet.ibm.com> <8739delvqz.fsf@linux.vnet.ibm.com> In-Reply-To: <8739delvqz.fsf@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1.0] 9pfs: improve portability to older systems List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Aneesh Kumar K.V" Cc: qemu-devel@nongnu.org On 11/23/2011 04:11 PM, Aneesh Kumar K.V wrote: >> > >> > virtio-9p-handle.c is only for recent Linux and you can assume the ioctl >> > is defined there. > But the file gets build by default right ? ie, we would build > virtio-9p-handle.c and if FS_IOC_GETVERSION is not defined, build will > fail right ? I think you're right. Strange that Erik did not see it. Paolo