From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Max Filippov <jcmvbkbc@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: avoid screening of --{en, dis}able-usb-redir options
Date: Thu, 24 Nov 2011 09:25:44 +0100 [thread overview]
Message-ID: <4ECDFF88.9040003@redhat.com> (raw)
In-Reply-To: <CAFEAcA9zWnr1WKp7-eWYnYJ0OsW8GSC9HBCnLhQzGqhz5Lf2rQ@mail.gmail.com>
On 11/23/2011 11:22 PM, Peter Maydell wrote:
> I just said this in the other thread, but to repeat it in the
> right place: I think we should expand out the case statement
> to explicitly list the --thingydir options it is supposed to
> be matching, and drop the wildcard: as this bug demonstrates
> it's rather easy to accidentally shoot yourself in the foot
> with it.
>
> In fact, what cases is this supposed to be matching? All
> the documented --thingydir options are handled explicitly
> earlier in the case statement.
>
> Paolo, you added this case in commit 6bde81cb0, but the
> commit message doesn't give any rationale; what's it for?
There were some --*dir that are supported by Autoconf and not by QEMU
configure. The aim was to let QEMU packagers use the rpm (or similar)
macro that overrides directories for their distribution.
next prev parent reply other threads:[~2011-11-24 8:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 21:53 [Qemu-devel] [PATCH] configure: avoid screening of --{en, dis}able-usb-redir options Max Filippov
2011-11-23 22:22 ` Peter Maydell
2011-11-24 8:25 ` Paolo Bonzini [this message]
2011-11-24 9:38 ` Peter Maydell
2011-11-24 9:57 ` Max Filippov
2011-11-24 10:01 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECDFF88.9040003@redhat.com \
--to=pbonzini@redhat.com \
--cc=jcmvbkbc@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).