From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36636)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RTUcw-0004s3-IF
	for qemu-devel@nongnu.org; Thu, 24 Nov 2011 03:25:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RTUcv-00069w-Et
	for qemu-devel@nongnu.org; Thu, 24 Nov 2011 03:25:50 -0500
Received: from mail-yx0-f173.google.com ([209.85.213.173]:44351)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RTUcv-00069r-7a
	for qemu-devel@nongnu.org; Thu, 24 Nov 2011 03:25:49 -0500
Received: by yenq2 with SMTP id q2so2708286yen.4
	for <qemu-devel@nongnu.org>; Thu, 24 Nov 2011 00:25:48 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4ECDFF88.9040003@redhat.com>
Date: Thu, 24 Nov 2011 09:25:44 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1322085218-10192-1-git-send-email-jcmvbkbc@gmail.com>
	<CAFEAcA9zWnr1WKp7-eWYnYJ0OsW8GSC9HBCnLhQzGqhz5Lf2rQ@mail.gmail.com>
In-Reply-To: <CAFEAcA9zWnr1WKp7-eWYnYJ0OsW8GSC9HBCnLhQzGqhz5Lf2rQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] configure: avoid screening of --{en,
 dis}able-usb-redir options
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Max Filippov <jcmvbkbc@gmail.com>, qemu-devel@nongnu.org

On 11/23/2011 11:22 PM, Peter Maydell wrote:
> I just said this in the other thread, but to repeat it in the
> right place: I think we should expand out the case statement
> to explicitly list the --thingydir options it is supposed to
> be matching, and drop the wildcard: as this bug demonstrates
> it's rather easy to accidentally shoot yourself in the foot
> with it.
>
> In fact, what cases is this supposed to be matching? All
> the documented --thingydir options are handled explicitly
> earlier in the case statement.
>
> Paolo, you added this case in commit 6bde81cb0, but the
> commit message doesn't give any rationale; what's it for?

There were some --*dir that are supported by Autoconf and not by QEMU 
configure.  The aim was to let QEMU packagers use the rpm (or similar) 
macro that overrides directories for their distribution.