From: Avi Kivity <avi@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Benoît Canet" <benoit.canet@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 07/11] bonito: convert north bridge register mapping to memory API
Date: Thu, 24 Nov 2011 10:40:57 +0200 [thread overview]
Message-ID: <4ECE0319.6020202@redhat.com> (raw)
In-Reply-To: <CAFEAcA8c57tSAPGv54oCv1SXAEAC_4nPBbaymHg_RsSD1nNFkg@mail.gmail.com>
On 11/23/2011 01:03 AM, Peter Maydell wrote:
> 2011/11/22 Benoît Canet <benoit.canet@gmail.com>:
> > static int bonito_initfn(PCIDevice *dev)
> > {
> > PCIBonitoState *s = DO_UPCAST(PCIBonitoState, dev, dev);
> > + SysBusDevice *sysbus = sysbus_from_qdev(&dev->qdev);
>
> This looks odd. The device here is a PCIBonitoState, which
> is-a PCIDevice, which is-a DeviceState. It's not a SysBusDevice
> and merely casting doesn't make it one.
>
> I'm not sure what should be being done here, but I'm pretty
> sure this won't work...
s->pcihost.busdev gives you a SysBusDevice (and
s->pcihost.confmem/datamem gives you a few MemoryRegions that you need
later in bonito_initfn.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-11-24 8:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 20:34 [Qemu-devel] [PATCH v3 00/11] more memory API conversions Benoît Canet
2011-11-22 20:34 ` [Qemu-devel] [PATCH v3 01/11] mcf5206: convert to memory API Benoît Canet
2011-11-22 20:34 ` [Qemu-devel] [PATCH v3 02/11] mcf_uart: " Benoît Canet
2011-11-22 20:34 ` [Qemu-devel] [PATCH v3 03/11] mcf_fec: " Benoît Canet
2011-11-22 20:34 ` [Qemu-devel] [PATCH v3 04/11] mcf_intc: " Benoît Canet
2011-11-22 20:34 ` [Qemu-devel] [PATCH v3 05/11] lm32_uart: " Benoît Canet
2011-11-22 20:34 ` [Qemu-devel] [PATCH v3 06/11] lm32_sys: " Benoît Canet
2011-11-22 20:34 ` [Qemu-devel] [PATCH v3 07/11] bonito: convert north bridge register mapping " Benoît Canet
2011-11-22 23:03 ` Peter Maydell
2011-11-23 17:55 ` Benoît Canet
2011-11-23 18:25 ` Peter Maydell
2011-11-24 8:40 ` Avi Kivity [this message]
2011-11-24 8:47 ` Benoît Canet
2011-11-22 20:34 ` [Qemu-devel] [PATCH v3 08/11] bonito: convert north bridge pci config " Benoît Canet
2011-11-22 20:35 ` [Qemu-devel] [PATCH v3 09/11] bonito: convert south " Benoît Canet
2011-11-22 20:35 ` [Qemu-devel] [PATCH v3 10/11] bonito: convert ldma " Benoît Canet
2011-11-22 20:35 ` [Qemu-devel] [PATCH v3 11/11] bonito: convert cop " Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECE0319.6020202@redhat.com \
--to=avi@redhat.com \
--cc=benoit.canet@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).