From: Avi Kivity <avi@redhat.com>
To: "Benoît Canet" <benoit.canet@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 00/11] more memory API conversions
Date: Thu, 24 Nov 2011 15:44:11 +0200 [thread overview]
Message-ID: <4ECE4A2B.1010402@redhat.com> (raw)
In-Reply-To: <1322141482-12173-1-git-send-email-benoit.canet@gmail.com>
On 11/24/2011 03:31 PM, Benoît Canet wrote:
> These patches convert some files to memory API
>
> I am wondering if the bonito ones are corrects as
> sysbus_mmio_map() use internally get_system_memory().
>From a "will it work" perspective, I think it's correct since it
system_memory is supposed to be equivalent to
cpu_register_physical_memory().
>From an "is this the right thing", well, we'll need to hack up sysbus
not to call get_system_memory() itself, but that's an unrelated problem.
> v2:
> remove unneeded casts in mcf_uart
> remove unneeded #include in lm32_uart and lm32_sys
>
> v3:
> use valid.accept in lm32_sys
>
> v4:
> bonito: use the pci_host sysbus pointer
> bonito: use pci_host->conf_mem and pci_host->data_mem
>
Looks good to me. I'll apply next week to allow people to review.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-11-24 13:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 13:31 [Qemu-devel] [PATCH v4 00/11] more memory API conversions Benoît Canet
2011-11-24 13:31 ` [Qemu-devel] [PATCH v4 01/11] mcf5206: convert to memory API Benoît Canet
2011-11-24 13:31 ` [Qemu-devel] [PATCH v4 02/11] mcf_uart: " Benoît Canet
2011-11-24 13:31 ` [Qemu-devel] [PATCH v4 03/11] mcf_fec: " Benoît Canet
2011-11-24 13:31 ` [Qemu-devel] [PATCH v4 04/11] mcf_intc: " Benoît Canet
2011-11-24 13:31 ` [Qemu-devel] [PATCH v4 05/11] lm32_uart: " Benoît Canet
2011-11-24 13:31 ` [Qemu-devel] [PATCH v4 06/11] lm32_sys: " Benoît Canet
2011-11-24 13:31 ` [Qemu-devel] [PATCH v4 07/11] bonito: convert north bridge register mapping " Benoît Canet
2011-11-24 13:43 ` Peter Maydell
2011-11-24 13:48 ` Avi Kivity
2011-11-24 13:31 ` [Qemu-devel] [PATCH v4 08/11] bonito: convert north bridge pci config " Benoît Canet
2011-11-24 13:31 ` [Qemu-devel] [PATCH v4 09/11] bonito: convert south " Benoît Canet
2011-11-24 13:31 ` [Qemu-devel] [PATCH v4 10/11] bonito: convert ldma " Benoît Canet
2011-11-24 13:31 ` [Qemu-devel] [PATCH v4 11/11] bonito: convert cop " Benoît Canet
2011-11-24 13:44 ` Avi Kivity [this message]
2011-11-27 8:38 ` [Qemu-devel] [PATCH v4 00/11] more memory API conversions Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECE4A2B.1010402@redhat.com \
--to=avi@redhat.com \
--cc=benoit.canet@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).