From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:38917)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RTs3Q-0007Zn-R1
	for qemu-devel@nongnu.org; Fri, 25 Nov 2011 04:26:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RTs3P-0000lW-Ky
	for qemu-devel@nongnu.org; Fri, 25 Nov 2011 04:26:44 -0500
Received: from mail-gy0-f173.google.com ([209.85.160.173]:34190)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1RTs3P-0000lG-8L
	for qemu-devel@nongnu.org; Fri, 25 Nov 2011 04:26:43 -0500
Received: by ghbg19 with SMTP id g19so3800244ghb.4
	for <qemu-devel@nongnu.org>; Fri, 25 Nov 2011 01:26:42 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4ECF5F46.3060402@redhat.com>
Date: Fri, 25 Nov 2011 10:26:30 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <w4hb1sgabh.wl%peter@chubb.wattle.id.au>
In-Reply-To: <w4hb1sgabh.wl%peter@chubb.wattle.id.au>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Who maintains checkpatch.pl now?
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Chubb <peter.chubb@nicta.com.au>
Cc: Blue Swirl <blauwirbel@gmail.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On 11/25/2011 04:17 AM, Peter Chubb wrote:
> If I fix the problem as in the appended patch, I start seeing other
> complaints:
>
> ERROR: space prohibited after that '*' (ctx:WxW)
> +#define PRIO_PER_WORD (sizeof (uint32_t) * 8 / 4)
>                                            ^

This was fixed recently in upstream Linux checkpatch, I posted a patch. 
  I'm ambivalent about the patch below; it's fine but perhaps we should 
fix sizeof occurrences followed by a space instead.  But it's just a 
warning.

Blue Swirl, can you please add yourself as checkpatch maintainer (in Odd 
Fixes status, I guess)?

Paolo

> Index: qemu-working/scripts/checkpatch.pl
> ===================================================================
> --- qemu-working.orig/scripts/checkpatch.pl	2011-11-10 10:16:43.215022488 +1100
> +++ qemu-working/scripts/checkpatch.pl	2011-11-25 14:02:30.908358997 +1100
> @@ -1953,21 +1953,21 @@ sub process {
>   		}
>
>   # check for spaces between functions and their parentheses.
>   		while ($line =~ /($Ident)\s+\(/g) {
>   			my $name = $1;
>   			my $ctx_before = substr($line, 0, $-[1]);
>   			my $ctx = "$ctx_before$name";
>
>   			# Ignore those directives where spaces_are_  permitted.
>   			if ($name =~ /^(?:
> -				if|for|while|switch|return|case|
> +				if|for|while|switch|return|case|sizeof|
>   				volatile|__volatile__|
>   				__attribute__|format|__extension__|
>   				asm|__asm__)$/x)
>   			{
>
>   			# cpp #define statements have non-optional spaces, ie
>   			# if there is a space between the name and the open
>   			# parenthesis it is simply not a parameter group.
>   			} elsif ($ctx_before =~ /^.\s*\#\s*define\s*$/) {
>