From: Fabien Chouteau <chouteau@adacore.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch
Date: Fri, 25 Nov 2011 15:46:12 +0100 [thread overview]
Message-ID: <4ECFAA34.6080309@adacore.com> (raw)
In-Reply-To: <4ECF71FD.9090308@redhat.com>
On 25/11/2011 11:46, Paolo Bonzini wrote:
> On 11/25/2011 11:24 AM, Fabien Chouteau wrote:
>>> For POSIX, it would be just a call to
>>> glib_select_fill+select+glib_select_poll. (Everything around
>>> these three would stay in the caller, and the fd_sets would be
>>> passed to os_host_main_loop_wait).
>>
>> Are you sure we have to use select()?
>
> slirp is fd_set---thus select()---based. iohandler too, though it would likely be simpler to switch it to poll().
Right, for slirp and iohandler, but it seems wrong to take file
descriptors from g_main_context_query() and put them in the fd_sets for
select(). This part is still in the code today.
--
Fabien Chouteau
next prev parent reply other threads:[~2011-11-25 14:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 13:12 [Qemu-devel] [PATCH 1/2] Add glib support to main loop Anthony Liguori
2011-08-22 13:12 ` [Qemu-devel] [PATCH 2/2] main: switch qemu_set_fd_handler to g_io_add_watch Anthony Liguori
2011-08-22 13:40 ` Paolo Bonzini
2011-08-22 13:45 ` Anthony Liguori
2011-08-22 13:47 ` Paolo Bonzini
2011-09-06 14:31 ` Paolo Bonzini
2011-09-06 15:59 ` Anthony Liguori
2011-09-07 7:03 ` Paolo Bonzini
2011-09-07 8:08 ` Jan Kiszka
2011-09-07 12:42 ` Anthony Liguori
2011-09-07 14:40 ` Paolo Bonzini
2011-09-07 14:53 ` Anthony Liguori
2011-09-07 15:26 ` Paolo Bonzini
2011-11-24 17:11 ` Fabien Chouteau
2011-11-24 17:30 ` Paolo Bonzini
2011-11-25 10:24 ` Fabien Chouteau
2011-11-25 10:46 ` Paolo Bonzini
2011-11-25 14:46 ` Fabien Chouteau [this message]
2011-11-25 14:49 ` Paolo Bonzini
2011-11-25 15:33 ` Fabien Chouteau
2011-11-25 15:48 ` Paolo Bonzini
2011-11-25 16:56 ` Fabien Chouteau
2011-11-25 19:36 ` Paolo Bonzini
2011-11-28 9:13 ` Fabien Chouteau
2011-09-04 14:03 ` Avi Kivity
2011-09-04 14:51 ` Anthony Liguori
2011-09-04 15:01 ` Anthony Liguori
2011-09-07 12:54 ` Avi Kivity
2011-09-05 9:46 ` Avi Kivity
2011-09-01 18:54 ` [Qemu-devel] [PATCH 1/2] Add glib support to main loop Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECFAA34.6080309@adacore.com \
--to=chouteau@adacore.com \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).