From: Avi Kivity <avi@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 1.0] malta: Fix regression (i8259 interrupts did not work)
Date: Sun, 27 Nov 2011 10:35:46 +0200 [thread overview]
Message-ID: <4ED1F662.2080501@redhat.com> (raw)
In-Reply-To: <4ECF3D37.80706@weilnetz.de>
On 11/25/2011 09:01 AM, Stefan Weil wrote:
>
> Boards normally have state structures, the device model
> supports this and is not wrong here.
>
> The Malta implementation simply needs conversion to qdev.
> This is something which will be done after QEMU 1.0.
>
> My patch is not the final solution. It's simply a hack to get
> a working Malta in QEMU 1.0. If the qdev solution is preferred
> for 1.0, I can also send a Malta qdev patch.
>
For 1.0, the simpler patch is better IMO (though I prefer g_new()
instead of static; g_new() is reentrant and catches the eye, while
static will hide from sight).
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-11-27 8:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 22:07 [Qemu-devel] [PATCH 1.0] malta: Fix regression (i8259 interrupts did not work) Stefan Weil
2011-11-24 23:21 ` Peter Maydell
2011-11-25 7:01 ` Stefan Weil
2011-11-27 8:35 ` Avi Kivity [this message]
2011-11-28 17:27 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED1F662.2080501@redhat.com \
--to=avi@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=aurelien@aurel32.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).