From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36831) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RUaDP-00039i-O8 for qemu-devel@nongnu.org; Sun, 27 Nov 2011 03:36:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RUaDO-0004Vy-L4 for qemu-devel@nongnu.org; Sun, 27 Nov 2011 03:35:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:23296) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RUaDO-0004Vu-Bn for qemu-devel@nongnu.org; Sun, 27 Nov 2011 03:35:58 -0500 Message-ID: <4ED1F662.2080501@redhat.com> Date: Sun, 27 Nov 2011 10:35:46 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1322172453-26340-1-git-send-email-sw@weilnetz.de> <4ECF3D37.80706@weilnetz.de> In-Reply-To: <4ECF3D37.80706@weilnetz.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1.0] malta: Fix regression (i8259 interrupts did not work) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Peter Maydell , Anthony Liguori , qemu-devel@nongnu.org, Aurelien Jarno On 11/25/2011 09:01 AM, Stefan Weil wrote: > > Boards normally have state structures, the device model > supports this and is not wrong here. > > The Malta implementation simply needs conversion to qdev. > This is something which will be done after QEMU 1.0. > > My patch is not the final solution. It's simply a hack to get > a working Malta in QEMU 1.0. If the qdev solution is preferred > for 1.0, I can also send a Malta qdev patch. > For 1.0, the simpler patch is better IMO (though I prefer g_new() instead of static; g_new() is reentrant and catches the eye, while static will hide from sight). -- error compiling committee.c: too many arguments to function